Matching a base path of another controller, results in 405 Method Not Allowed

[ivansenic]

Describe the bug

It took me some time to understand the bug I am hitting, but now I am pretty certain it's a bug and it's reproducible. Let's imagine you have two controllers:

@Path("/base")
class Base {

   @GET
   @Path("{id}") 
   public Uni<RestResponse<?>> base() {..}
}

@Path("/base/{id}")
class Extension {

   @GET
   @Path("extension") 
   public Uni<RestResponse<?>> extension() {..}
}

Calling GET /base/123 will result in HTTP 405 Method Not Allowed. Note that:

• endpoints are correctly visible in the Dev UI List of endpoints
• endpoints are correctly included in Open API and Swagger UI

However, seems that the base-path of the second controller is hiding the first controller in case when things are getting resolved in the org.jboss.resteasy.reactive.server.handlers.ClassRoutingHandler.

Expected behavior

Target method executed correctly.

Actual behavior

405 Method Not Allowed

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.10.0.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Maven home: /home/ise/.m2/wrapper/dists/apache-maven-3.8.4-bin/52ccbt68d252mdldqsfsn03jlf/apache-maven-3.8.4 Java version: 17.0.3, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.13.0-51-generic", arch: "amd64", family: "unix"

Additional information

Workaround is to match base paths in both controllers:

@Path("/base")
class Base {

   @GET
   @Path("{id}") 
   public Uni<RestResponse<?>> base() {..}
}

@Path("/base")
class Extension {

   @GET
   @Path("{id}/extension") 
   public Uni<RestResponse<?>> extension() {..}
}

[geoand]

I am not sure this is allowed as per the JAX-RS spec.
@sberyozkin, @FroMage do you know?

[quarkus-bot]

/cc @FroMage, @stuartwdouglas

[ivansenic]

I am not sure this is allowed as per the JAX-RS spec. @sberyozkin, @FroMage do you know?

Really? Hmm, I know this is possible in Spring, although the have different annotations..

OK if this is the case, then it's my bad..

[geoand]

Really? Hmm, I know this is possible in Spring, although the have different annotations..

Spring doesn't implement JAX-RS :)

OK if this is the case, then it's my bad..

I'm not sure either, lets see if others know for sure

[FroMage]

Well, frankly, the JAX-RS spec routing algo I never understood: https://jakarta.ee/specifications/restful-ws/3.1/jakarta-restful-ws-spec-3.1.html#request_matching

But the use-case looks legit to me, both classes should be analogous IMO, since in both cases the endpoints have the same URIs. So IMO we should support this.

[geoand]

I agree it would be useful

[pehunka]

Hi team, same issue here .. is there anything I can do to workaround it?

[geoand]

For the time being, only to not have overlapping paths.

But we should definitely address this one