Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus-cli 2.8.2.Final create app doesn't include test examples with just a jacoco extension #25761

Closed
pjgg opened this issue May 24, 2022 · 4 comments
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working triage/invalid This doesn't seem right

Comments

@pjgg
Copy link
Contributor

pjgg commented May 24, 2022

Describe the bug

Quarkus 2.8.2.Final and also Upstream (999-SNAPSHOT)
Worked as expected with Quarkus 2.7.5.Final

Quarkus-cli 2.8.2.final doesn't add a quarkus-resteasy extension by default, so if I create an application with just jacoco extension then I don't have a test folder. I am not sure if this could be an issue?

Reproducer:

  1. create an app with jacoco extension
    quarkus create app app -x=jacoco

  2. build your app
    quarkus build

  3. Verify is a jacoco folder was created

ls target 
app-1.0.0-SNAPSHOT.jar  classes  generated-sources  maven-archiver  maven-status  quarkus-app  quarkus-artifact.properties

No jacoco report was generated because there is no test folder/examples.

@pjgg pjgg added the kind/bug Something isn't working label May 24, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented May 24, 2022

/cc @ebullient, @maxandersen

@quarkus-bot quarkus-bot bot added the area/cli Related to quarkus cli (not maven/gradle/etc.) label May 24, 2022
@pjgg pjgg changed the title Quarkus-cli 2.8.2.Final create app doesn't include test examples Quarkus-cli 2.8.2.Final create app doesn't include test examples with just a jacoco extension May 24, 2022
@gsmet
Copy link
Member

gsmet commented May 24, 2022

Yes, we are not forcing a REST implementation on the users anymore IF they specify at least an extension.
If they want one, they need to specify it.

If they don't specify any extension, they end up with a RESTEasy Reactive example.

@geoand
Copy link
Contributor

geoand commented May 25, 2022

Should this be closed?

@pjgg
Copy link
Contributor Author

pjgg commented May 25, 2022

Ok, got it! thank you @gsmet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/bug Something isn't working triage/invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants