Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitch OIDC Provider #24833

Closed
gastaldi opened this issue Apr 8, 2022 · 18 comments · Fixed by #29244
Closed

Add Twitch OIDC Provider #24833

gastaldi opened this issue Apr 8, 2022 · 18 comments · Fixed by #29244
Labels
area/oidc good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@gastaldi
Copy link
Contributor

gastaldi commented Apr 8, 2022

Description

See https://dev.twitch.tv/docs/authentication/getting-tokens-oidc/#oidc-authorization-code-grant-flow

Implementation ideas

No response

@gastaldi gastaldi added kind/enhancement New feature or request area/oidc labels Apr 8, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 8, 2022

/cc @pedroigor, @sberyozkin

@sberyozkin
Copy link
Member

sberyozkin commented Apr 8, 2022

Hey @gastaldi It should already work in Quarkus, but once we confirm it we will add an option to configure it compactly, instead of using 10 properties, I'm on PTO, will ping next week to discuss the details

@gastaldi gastaldi added the good first issue Good for newcomers label Apr 8, 2022
@VanillaSpoon
Copy link
Contributor

Hey :) could I take a shot at this issue?

@sberyozkin
Copy link
Member

sberyozkin commented Apr 10, 2022

Sure, it would be great. Please see #24823 for more information, the scope of this issue would be similar

@VanillaSpoon
Copy link
Contributor

Thanks @sberyozkin :)

@sberyozkin
Copy link
Member

@VanillaSpoon Np at all, thanks to @gastaldi for creating this good first issue

@VanillaSpoon
Copy link
Contributor

Hey @sberyozkin @gastaldi apologies for the delay with this. Had some setbacks but I will have a PR early this week :)

@sberyozkin
Copy link
Member

@VanillaSpoon Np, take your time please

@sberyozkin
Copy link
Member

@VanillaSpoon By the way, once you confirm it is working, please also have this document updated which should be merged shortly: #25197. Add a Twitch section after Spotify and a few images explaining how to set up an application in Twitch, thanks

@geoand
Copy link
Contributor

geoand commented Aug 30, 2022

Has this been implemented?

@VanillaSpoon
Copy link
Contributor

Hi @geoand
Sorry, I am unable to complete this currently. Would it be ok if I pass on the ticket?

@geoand
Copy link
Contributor

geoand commented Aug 30, 2022

Absolutely, thanks for letting us know

@biswassri
Copy link
Contributor

@geoand If it's not already taken care of, could I give this a try?

@geoand
Copy link
Contributor

geoand commented Sep 1, 2022

Go for it :)

@sberyozkin
Copy link
Member

@VanillaSpoon Hey, np at all, thanks for the update. Welcome @biswassri

@geoand
Copy link
Contributor

geoand commented Oct 19, 2022

@biswassri hey, just checking in :). Were you able to look into this?

@biswassri
Copy link
Contributor

@geoand hey! Yes, I have been able to progress on it and I'm currently testing out my changes. I'm hopeful I should have a PR by early next week. Sorry for the delay!

@biswassri biswassri removed their assignment Mar 2, 2023
@Harshitsoni2000
Copy link

Hi @geoand, @sberyozkin, is this still open? If so, I would love to work on Twitch Integration.

@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants