Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim configuration values automatically in the quarkus namespace #22841

Open
radcortez opened this issue Jan 12, 2022 · 0 comments
Open

Trim configuration values automatically in the quarkus namespace #22841

radcortez opened this issue Jan 12, 2022 · 0 comments
Labels
area/config kind/enhancement New feature or request

Comments

@radcortez
Copy link
Member

Description

Because of the way that properties files work, configuration values may contain trailing whitespaces when read from this type of configuration source. The rationale was to not mess with the value because we don't know if the whitespace is intended or not.

Unfortunately, this seems to cause more harm than good:

The fix usually requires us to go to the problematic property and apply the TrimmingConverter.

Implementation ideas

We could trim automatically every property in the quarkus namespace. This will probably fix all related issues (and future issues) and still keep the original behavior for user configuration.

Potentially, this can be a breaking / inconvenient change even for quarkus configuration. Thinking about properties that set names to be passed to other services that may contain trailing whitespaces, so we need to discuss this carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant