NPE on build when decorator is injected a delegate that is a subtype of the decorated interface

[xtaixe]

Describe the bug

Getting:

Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[ERROR] 	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#generateResources threw an exception: java.lang.NullPointerException
[ERROR] 	at io.quarkus.arc.processor.SubclassGenerator.processDecorator(SubclassGenerator.java:572)
[ERROR] 	at io.quarkus.arc.processor.SubclassGenerator.createConstructor(SubclassGenerator.java:199)
[ERROR] 	at io.quarkus.arc.processor.SubclassGenerator.generate(SubclassGenerator.java:118)
[ERROR] 	at io.quarkus.arc.processor.BeanProcessor.generateResources(BeanProcessor.java:205)
[ERROR] 	at io.quarkus.arc.deployment.ArcProcessor.generateResources(ArcProcessor.java:462)

when using a subtype as a delegate instead of the decorated interface.

Expected behavior

Project builds and decorator and beans are handled properly.

Actual behavior

NPE on build

How to Reproduce?

No response

Output of uname -a or ver

Darwin xtaixe 20.6.0 Darwin Kernel Version 20.6.0: Tue Oct 12 18:33:42 PDT 2021; root:xnu-7195.141.8~1/RELEASE_X86_64 x86_64

Output of java -version

openjdk 11.0.13 2021-10-19 OpenJDK Runtime Environment GraalVM CE 21.3.0 (build 11.0.13+7-jvmci-21.3-b05) OpenJDK 64-Bit Server VM GraalVM CE 21.3.0 (build 11.0.13+7-jvmci-21.3-b05, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.5.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Maven 3.8.4

Additional information

No response

[xtaixe]

Unfortunately I haven't been able to create a small reproducer for now. Hopefully the stacktrace gives an idea of what might be happening. Happy to answer any questions that might help figuring this out or taking any suggestions on what could be causing the error to try to create a small reproducer.

[xtaixe]

It seems it's related to priority of decorators cause if I add a priority to the decorator that uses the subtype the build works fine. So that it's easier to understand, I have something like this:

public interface A {}

@ApplicationScoped
public class B implements A {}


@Decorator
public class C implements A {

    private final A a;

    @Inject
    public C(@Delegate A a) {
        this.a = a;
    }

}

@Decorator
public class D implements A {

    private final A a;

    @Inject
    public D(@Delegate B b) {
        this.a = b;
    }

}

but I still haven't been able to make it fail on a small reproducer like this.

[quarkus-bot]

/cc @manovotn, @mkouba

[mkouba]

@xtaixe I wasn't able to reproduce this particular error either but I found other problem and this PR should fix it.

[xtaixe]

Interesting... @mkouba would the test you added not pass without the changes? Anyway, I can test if this fixes my issue as soon as there's a release with those changes. Are there daily builds or similar?

[mkouba]

Interesting... @mkouba would the test you added not pass without the changes?

Well, I only added the ping() method so that I can test the decoration itself...

Anyway, I can test if this fixes my issue as soon as there's a release with those changes. Are there daily builds or similar?

I don't think that this PR can actually fix your problem but +1 if you can try it ;-)

Are there daily builds or similar?

I believe that snapshots are deployed to https://s01.oss.sonatype.org/content/repositories/snapshots/ once a day or so. But it's very easy to build the snapshot locally - just clone the repo and run mvn clean install -Dquickly -T 1.

[mkouba]

@xtaixe would you care to verify that the problem still exists?

[xtaixe]

@mkouba yes, still happening on 2.7.5.Final

[mkouba]

@mkouba yes, still happening on 2.7.5.Final

Well, in that case we'll need more information. Would you care to create a simple reproducer app/test?

[xtaixe]

I already tried unsuccessfully at the time I raised the issue. I'll try again if I find the time, but I doubt my luck will change.

[geoand]

Closing as we never got a reproducer