Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json format issue with quarkus 2.5.0.Final at patch request #21768

Closed
RehamAboelyazied7 opened this issue Nov 29, 2021 · 5 comments
Closed

json format issue with quarkus 2.5.0.Final at patch request #21768

RehamAboelyazied7 opened this issue Nov 29, 2021 · 5 comments
Labels
kind/bug Something isn't working triage/duplicate This issue or pull request already exists

Comments

@RehamAboelyazied7
Copy link

RehamAboelyazied7 commented Nov 29, 2021

Describe the bug

I was using quarkus 2.4.1.Final and implemented a patch request with quarkus-resteasy-jackson
now, I need to update to 2.5.0.Final but when I try updating it, the format of response is not right and I get an error parsing JSON data.

Expected behavior

the expected was to have the same json response as before

Actual behavior

the response code is 200 as before but with miss match json format - error to parse json

How to Reproduce?

find sample project for the problem: https://github.com/RehamAboelyazied7/mongo-with-quarkus

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

@RehamAboelyazied7 RehamAboelyazied7 added the kind/bug Something isn't working label Nov 29, 2021
@geoand
Copy link
Contributor

geoand commented Nov 29, 2021

Can you please attach a sample project the exhibits the problem you mention?

@geoand geoand added triage/needs-reproducer We are waiting for a reproducer. and removed triage/needs-triage labels Nov 29, 2021
@RehamAboelyazied7
Copy link
Author

@geoand I updated it with github repository link for sample

@geoand geoand removed the triage/needs-reproducer We are waiting for a reproducer. label Nov 30, 2021
@geoand
Copy link
Contributor

geoand commented Nov 30, 2021

I see that your reproducer depends on another service that is not included.

So I used what you specified in the issue:

@Path("/testPath")
public class MyResource {
    @PATCH
    @Path("/{id}")
    @Produces(MediaType.APPLICATION_JSON)
    @Consumes(MediaType.APPLICATION_JSON)
    public Response myPatch(@PathParam("id") String id){
      return Response.ok(id).build();
   }
}

and it worked as expected

@RehamAboelyazied7
Copy link
Author

I checked that #21818 and I think it's the same issue

@geoand
Copy link
Contributor

geoand commented Nov 30, 2021

Very interesting.

Let's close this then since the underlying issue has already been fixed.

Once 2.5.1 is out, please give it a try and comment if the issue has not been fixed

@geoand geoand closed this as completed Nov 30, 2021
@geoand geoand added the triage/duplicate This issue or pull request already exists label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants