Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-avro: support UUID logical type #21529

Closed
VoidAspect opened this issue Nov 18, 2021 · 4 comments · Fixed by #22315
Closed

quarkus-avro: support UUID logical type #21529

VoidAspect opened this issue Nov 18, 2021 · 4 comments · Fixed by #22315
Labels
kind/enhancement New feature or request
Milestone

Comments

@VoidAspect
Copy link

Description

Currently, the "uuid" logical type in the .avsc schema is interpreted as a String, and there's no validation to check if this string is a valid UUID.

Implementation ideas

We can use an existing org.apache.avro.Conversions.UUIDConversion class and register it on the compiler.

@glefloch
Copy link
Member

instead on registering the convertor, I think we could add an option that allow to list convertor to register? WDYT @michalszynkiewicz ?

@michalszynkiewicz
Copy link
Member

sounds good to me

@gsmet
Copy link
Member

gsmet commented Dec 16, 2021

I'm not that familiar with Avro but I think I would do both. UUID seems very widely used so I think it would make sense to have it enabled by default. But I'm not sure if it can break something to have it.

/cc @cescoffier

@glefloch
Copy link
Member

sure we can do both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants