You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With open-telemetry extension installed and enabled, the default behaviour is to ignore non application uri suppress-non-application-uris: true
With the default sampler implementation at runtime we got aNonApplicationEndpointSampler instantiated.
The default implementation doesn't take in consideration the application context root
@Override
public SamplingResult shouldSample(Context parentContext, String traceId, String name, SpanKind spanKind,
Attributes attributes, List<LinkData> parentLinks) {
// if context-root is myapplication, name will be myapplication/q/health/ready
// so this check will fail
if (name.startsWith("q/") && spanKind == SpanKind.SERVER) {
return NEGATIVE_SAMPLING_RESULT;
}
return root.shouldSample(parentContext, traceId, name, spanKind, attributes, parentLinks);
}
Expected behavior
If my application context-root is myapplication every request under myapplication/q/* should be ignored by the sampler if suppress-non-application-uris is true
Actual behavior
Actually every check under myapplication/q/* get sampled.
How to Reproduce?
No response
Output of uname -a or ver
No response
Output of java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of mvnw --version or gradlew --version)
No response
Additional information
No response
The text was updated successfully, but these errors were encountered:
Yes, the plan is to implement that. OTel is going to offer an API to disable selected endpoints, but we need to move to their config API, which is missing a few things for us to use properly. I'm discussing this with the OTel community, so we can add what is missing.
Thinking about this a little better, it may take a while for us to have OTel fully integrated to use their config for this. I'll probably just add it directly into Quarkus for now.
Describe the bug
With open-telemetry extension installed and enabled, the default behaviour is to ignore non application uri
suppress-non-application-uris: true
With the default sampler implementation at runtime we got a
NonApplicationEndpointSampler
instantiated.The default implementation doesn't take in consideration the application context root
Expected behavior
If my application context-root is
myapplication
every request undermyapplication/q/*
should be ignored by the sampler ifsuppress-non-application-uris
istrue
Actual behavior
Actually every check under
myapplication/q/*
get sampled.How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: