Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - adjust interception of overriden lifecycle methods accordingly to specification #19678

Closed
manovotn opened this issue Aug 26, 2021 · 1 comment · Fixed by #19679
Closed
Assignees
Labels
area/arc Issue related to ARC (dependency injection) kind/bug Something isn't working
Milestone

Comments

@manovotn
Copy link
Contributor

manovotn commented Aug 26, 2021

Arc behavior doesn't correspond to Interceptors specification in its treatment of @Predestroy and @PostConstruct callbacks. Currently, we collect and invoke all in the hierarchy but we don't look at whether the method was overriden. If it was, that method should not be invoked.

CDI TCK test asserting this - https://github.com/eclipse-ee4j/cdi-tck/blob/master/impl/src/main/java/org/jboss/cdi/tck/interceptors/tests/order/overriden/lifecycleCallback/OverridenLifecycleCallbackInterceptorTest.java

And here's the interceptor spec part detailing this (the end of this paragraph) - https://jakarta.ee/specifications/interceptors/2.0/interceptors-spec-2.0.html#interceptor_ordering_rules

@manovotn manovotn added kind/bug Something isn't working area/arc Issue related to ARC (dependency injection) labels Aug 26, 2021
@manovotn manovotn self-assigned this Aug 26, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 26, 2021

/cc @mkouba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bug Something isn't working
Projects
None yet
1 participant