Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin quarkus:add-extension should add more than just import #1940

Closed
FroMage opened this issue Apr 9, 2019 · 7 comments
Closed

Maven plugin quarkus:add-extension should add more than just import #1940

FroMage opened this issue Apr 9, 2019 · 7 comments
Labels
area/maven area/user-experience Will make us lose users kind/enhancement New feature or request pinned Issue will never be marked as stale triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@FroMage
Copy link
Member

FroMage commented Apr 9, 2019

When I add extensions like resteasy or hibernate-orm or hibernate-orm-panache I want to add a REST endpoint in the first case, and default config and an entity in the second case.

Is this something we can do or does it belong in another tool?

@FroMage FroMage added kind/enhancement New feature or request area/maven area/user-experience Will make us lose users labels Apr 9, 2019
@cescoffier
Copy link
Member

That's something I would love to have!

It would require that the extension list give the set of properties that need to be copied to the application configuration.

@Dufgui
Copy link
Contributor

Dufgui commented Aug 23, 2019

In my opinion, it's quite simple to add some extra data in devtools-common, but I think we want something not centralized. Each plugin must provide it's own templated files.
So 2 ways:

  1. We ask to gradle or maven to download it, and the we explore them to get the templated file and produce them
  2. We let them with a properties in maven or gradle and on the next build we generate the file by the extension and remove the properties to not do it again at next build

Any other idea ?
@cescoffier @FroMage

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you!
We are doing this automatically to ensure out-of-date issues does not stay around indefinitely.
If you believe this issue is still relevant please put a comment on it on why and if it truly needs to stay request or add 'pinned' label.

@stale stale bot added the stale label Nov 13, 2019
@FroMage FroMage added the pinned Issue will never be marked as stale label Nov 13, 2019
@stale stale bot removed the stale label Nov 13, 2019
@ia3andy
Copy link
Contributor

ia3andy commented Apr 1, 2020

This is a must have and going to be part of #8134

@Dufgui
Copy link
Contributor

Dufgui commented Apr 1, 2020

Could I help on this. ? Nobody reply to me but I am really interested on this

@Dufgui
Copy link
Contributor

Dufgui commented Dec 28, 2020

Hello, i see the introduction of codestart in devtools platform. So i think you can close it.

@ia3andy
Copy link
Contributor

ia3andy commented Jan 4, 2021

Yes we can close it

@ia3andy ia3andy closed this as completed Jan 4, 2021
@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maven area/user-experience Will make us lose users kind/enhancement New feature or request pinned Issue will never be marked as stale triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

5 participants