Injecting ConfigMapping in resteasy containerrequestfilter causes NoSuchElementException #18333

Postremus · 2021-07-02T06:35:52Z

Describe the bug

This one is quite similar to #17466, except this issue is about containerrequestfilter, while the other was about requestscoped observer.

@Provider
public class Filter implements ContainerRequestFilter {
    @Inject
    SomeConfigMapping config;

    @Override public void filter(ContainerRequestContext requestContext) throws IOException {
        System.out.println(config.value());
    }
}

@ConfigMapping(prefix = "some")
public interface SomeConfigMapping {
    @WithName("value")
    String value();
}

Expected behavior

App should start without problems.

Actual behavior

2021-07-02 08:32:01,404 INFO  [io.qua.dep.dev.IsolatedDevModeMain] (main) Attempting to start live reload endpoint to recover from previous Quarkus startup failure
2021-07-02 08:32:01,404 ERROR [io.qua.run.boo.StartupActionImpl] (Quarkus Main Thread) Error running Quarkus: java.lang.reflect.InvocationTargetException
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:98)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.ExceptionInInitializerError
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
        at java.base/java.lang.Class.newInstance(Class.java:584)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:65)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:42)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:119)
        at io.quarkus.runner.GeneratedMain.main(GeneratedMain.zig:29)
        ... 6 more
Caused by: java.lang.RuntimeException: Failed to start quarkus
        at io.quarkus.runner.ApplicationImpl.<clinit>(ApplicationImpl.zig:291)
        ... 15 more
Caused by: java.lang.RuntimeException: Error injecting org.acme.SomeConfigMapping org.acme.Filter.config
        at org.acme.Filter_Bean.create(Filter_Bean.zig:199)
        at org.acme.Filter_Bean.create(Filter_Bean.zig:222)
        at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:96)
        at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:29)
        at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:26)
        at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:26)
        at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69)
        at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:26)
        at org.acme.Filter_Bean.get(Filter_Bean.zig:254)
        at org.acme.Filter_Bean.get(Filter_Bean.zig:270)
        at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:430)
        at io.quarkus.arc.impl.ArcContainerImpl.beanInstanceHandle(ArcContainerImpl.java:443)
        at io.quarkus.arc.impl.ArcContainerImpl$1.get(ArcContainerImpl.java:266)
        at io.quarkus.arc.impl.ArcContainerImpl$1.get(ArcContainerImpl.java:263)
        at io.quarkus.resteasy.common.runtime.QuarkusConstructorInjector.construct(QuarkusConstructorInjector.java:39)
        at org.jboss.resteasy.core.providerfactory.ResteasyProviderFactoryImpl.injectedInstance(ResteasyProviderFactoryImpl.java:1399)
        at org.jboss.resteasy.core.interception.jaxrs.JaxrsInterceptorRegistryImpl$AbstractInterceptorFactory.createInterceptor(JaxrsInterceptorRegistryImpl.java:150)
        at org.jboss.resteasy.core.interception.jaxrs.JaxrsInterceptorRegistryImpl$OnDemandInterceptorFactory.initialize(JaxrsInterceptorRegistryImpl.java:168)
        at org.jboss.resteasy.core.interception.jaxrs.JaxrsInterceptorRegistryImpl$OnDemandInterceptorFactory.checkInitialize(JaxrsInterceptorRegistryImpl.java:183)
        at org.jboss.resteasy.core.interception.jaxrs.JaxrsInterceptorRegistryImpl$OnDemandInterceptorFactory.getInterceptor(JaxrsInterceptorRegistryImpl.java:193)
        at org.jboss.resteasy.core.interception.jaxrs.JaxrsInterceptorRegistryImpl$AbstractInterceptorFactory.postMatch(JaxrsInterceptorRegistryImpl.java:131)
        at org.jboss.resteasy.core.interception.jaxrs.JaxrsInterceptorRegistryImpl.postMatch(JaxrsInterceptorRegistryImpl.java:288)
        at org.jboss.resteasy.core.interception.jaxrs.ContainerRequestFilterRegistryImpl.postMatch(ContainerRequestFilterRegistryImpl.java:30)
        at org.jboss.resteasy.core.interception.jaxrs.ContainerRequestFilterRegistryImpl.postMatch(ContainerRequestFilterRegistryImpl.java:12)
        at org.jboss.resteasy.core.ResourceMethodInvoker.<init>(ResourceMethodInvoker.java:142)
        at org.jboss.resteasy.core.ResourceMethodRegistry.processMethod(ResourceMethodRegistry.java:381)
        at org.jboss.resteasy.core.ResourceMethodRegistry.register(ResourceMethodRegistry.java:308)
        at org.jboss.resteasy.core.ResourceMethodRegistry.addResourceFactory(ResourceMethodRegistry.java:259)
        at org.jboss.resteasy.core.ResourceMethodRegistry.addResourceFactory(ResourceMethodRegistry.java:227)
        at org.jboss.resteasy.core.ResourceMethodRegistry.addResourceFactory(ResourceMethodRegistry.java:208)
        at org.jboss.resteasy.core.ResourceMethodRegistry.addResourceFactory(ResourceMethodRegistry.java:192)
        at org.jboss.resteasy.core.ResourceMethodRegistry.addResourceFactory(ResourceMethodRegistry.java:175)
        at org.jboss.resteasy.core.ResourceMethodRegistry.addPerRequestResource(ResourceMethodRegistry.java:87)
        at org.jboss.resteasy.core.ResteasyDeploymentImpl.registerResources(ResteasyDeploymentImpl.java:518)
        at org.jboss.resteasy.core.ResteasyDeploymentImpl.registration(ResteasyDeploymentImpl.java:475)
        at org.jboss.resteasy.core.ResteasyDeploymentImpl.startInternal(ResteasyDeploymentImpl.java:164)
        at org.jboss.resteasy.core.ResteasyDeploymentImpl.start(ResteasyDeploymentImpl.java:121)
        at io.quarkus.resteasy.runtime.standalone.ResteasyStandaloneRecorder.staticInit(ResteasyStandaloneRecorder.java:37)
        at io.quarkus.deployment.steps.ResteasyStandaloneBuildStep$staticInit-210558872.deploy_0(ResteasyStandaloneBuildStep$staticInit-210558872.zig:903)
        at io.quarkus.deployment.steps.ResteasyStandaloneBuildStep$staticInit-210558872.deploy(ResteasyStandaloneBuildStep$staticInit-210558872.zig:40)
        at io.quarkus.runner.ApplicationImpl.<clinit>(ApplicationImpl.zig:260)
        ... 15 more
Caused by: java.util.NoSuchElementException: SRCFG00027: Could not find a mapping for org.acme.SomeConfigMapping
        at io.smallrye.config.ConfigMappings.getConfigMapping(ConfigMappings.java:73)
        at io.smallrye.config.SmallRyeConfig.getConfigMapping(SmallRyeConfig.java:357)
        at io.quarkus.arc.runtime.ConfigMappingCreator.create(ConfigMappingCreator.java:28)
        at org.acme.SomeConfigMapping_2d5671bb9f49e16a6bde817d1dc2ee2e8da3440b_Synthetic_Bean.create(SomeConfigMapping_2d5671bb9f49e16a6bde817d1dc2ee2e8da3440b_Synthetic_Bean.zig:128)
        at org.acme.SomeConfigMapping_2d5671bb9f49e16a6bde817d1dc2ee2e8da3440b_Synthetic_Bean.get(SomeConfigMapping_2d5671bb9f49e16a6bde817d1dc2ee2e8da3440b_Synthetic_Bean.zig:159)
        at org.acme.SomeConfigMapping_2d5671bb9f49e16a6bde817d1dc2ee2e8da3440b_Synthetic_Bean.get(SomeConfigMapping_2d5671bb9f49e16a6bde817d1dc2ee2e8da3440b_Synthetic_Bean.zig:182)
        at io.quarkus.arc.impl.CurrentInjectionPointProvider.get(CurrentInjectionPointProvider.java:52)
        at org.acme.Filter_Bean.create(Filter_Bean.zig:182)
        ... 55 more

2021-07-02 08:32:01,467 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.0.Final

To Reproduce

Steps to reproduce the behavior:

Download the reproducer:
requestscoped-test.zip
mvn quarkus:dev
app does not start
Remove the filter class
mvn quarkus:dev
The app starts

Configuration

some.value=abc

Environment (please complete the following information):

Output of `uname -a` or `ver`

MSYS_NT-10.0 NANB7NLNVP2 2.10.0(0.325/5/3) 2018-06-13 23:34 x86_64 Msys

Output of `java -version`

openjdk 11.0.7 2020-04-14 LTS
OpenJDK Runtime Environment Zulu11.39+15-CA (build 11.0.7+10-LTS)
OpenJDK 64-Bit Server VM Zulu11.39+15-CA (build 11.0.7+10-LTS, mixed mode)

Quarkus version or git rev

2.0.0.Final

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: C:\eclipse\tools\apache-maven\bin..
Java version: 11.0.7, vendor: Azul Systems, Inc., runtime: C:\eclipse\tools\java\11
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

The text was updated successfully, but these errors were encountered:

Postremus · 2021-07-02T06:36:51Z

/cc @radcortez fyi

gsmet · 2021-07-02T06:55:21Z

/cc @geoand too

geoand · 2021-07-02T06:57:23Z

@radcortez why would this be happening? What is special about @ConfigMapping that would cause this?
Or is the problem that the mapping is getting instantiated too early?

Is this perhaps similar to #18237 ?

radcortez · 2021-07-02T09:05:56Z

Yes, the mappings are only registered for the runtime Config instance, not for static config.

Again, that is on purpose, because not every source may be available on static init, and the config behavior may differ from static to init (calls to the same property name may yield different results).

Still, this seems to be something that users are relying on, so we can support it. I was already planning to move the registration code to the config generator.

gsmet · 2021-09-06T15:22:01Z

The PR fixing this has been reverted for now. A future fix is expected but we have no timeline for it.

boev · 2022-03-18T15:53:59Z

For me this still happens in quarkus 2.7.1:
<quarkus.platform.version>2.7.1.Final</quarkus.platform.version>

I have a property Class mapped with @ConfigMapping. Injecting the property class inside

public class SomeRequestFilter implements ContainerRequestFilter

Fails the Application with "Could not find mapping for ...."
Injecting the property class anywhere else works.

radcortez · 2022-03-18T17:18:42Z

Is your mapping annotated with @StaticInitSafe?

boev · 2022-03-21T13:59:54Z

Hi @radcortez, annotating my property interface like this:

@ConfigMapping(prefix = "some.properties")
@StaticInitSafe
public interface SomeProperties {
    
}

made it injectable in my public class SomeRequestFilter implements ContainerRequestFilter.

Thank you very much for the quick help.

holly-cummins · 2023-02-09T23:04:06Z

I found my application would work on startup, but then crash on hot reload, if I marked my config @StaticInitSafe. I guess the config I was looking at really wasn't safe for static init. :)

However, the solution in https://stackoverflow.com/questions/68769397/jar-rs-filter-injection-of-a-cdi-singleton-that-reference-a-configmapping-objec seems to be working for me. Wrapping my config (or the thing that uses it) in @Instance defers the access (I assume?) until everything is nicely initialised, and so there's no crashes.

radcortez · 2023-02-10T09:14:28Z

I found my application would work on startup, but then crash on hot reload, if I marked my config @StaticInitSafe. I guess the config I was looking at really wasn't safe for static init. :)

:)

However, the solution in https://stackoverflow.com/questions/68769397/jar-rs-filter-injection-of-a-cdi-singleton-that-reference-a-configmapping-objec seems to be working for me. Wrapping my config (or the thing that uses it) in @Instance defers the access (I assume?) until everything is nicely initialised, and so there's no crashes.

The main issue is that filters are initialized at static init. Some configuration sources are not available at static init, because dependent services are not available yet to retrieve them (think for instance, a database-based config source). The @StaticInitSafe is used to mark config component that is safe to be loaded during static init (does not contain a configuration that required retrieval from a database - not available yet - and because of it fails).

The live reloading might be another issue. I've recently improved the dev reload for configuration in #30964. I hope that helps.

holly-cummins · 2023-02-10T09:19:22Z

Thanks, @radcortez! Oddly, the configuration that was causing failures if I marked it @StaticInitSafe was quarkus.application.name, so definitely no databases involved. It sounds like #30964 might fix the hot reload issue, so I'll have a try with that once it's in a release to see if I can drop the Instance< wrapper and go back to @StaticInitSafe.

radcortez · 2023-02-10T11:07:33Z

Sure, let me know if that fixes it. If not, I'll have a look.

Postremus added the kind/bug Something isn't working label Jul 2, 2021

quarkus-bot bot added the env/windows Impacts Windows machines label Jul 2, 2021

gsmet added the area/config label Jul 2, 2021

radcortez mentioned this issue Jul 7, 2021

Register @ConfigMappings directly into the Config builder #18497

Merged

2 tasks

radcortez self-assigned this Jul 7, 2021

gsmet closed this as completed in #18497 Aug 12, 2021

quarkus-bot bot added this to the 2.2 - main milestone Aug 12, 2021

This was referenced Sep 6, 2021

Arc: Regression issue when mapping @ConfigMapping using a custom ConfigSource implementation #19448

Closed

Revert "Register @ConfigMappings directly into the Config builder" #19937

Merged

gsmet reopened this Sep 6, 2021

gsmet removed this from the 2.2.0.CR1 milestone Sep 6, 2021

radcortez mentioned this issue Sep 13, 2021

Register @ConfigMappings directly into the Config builder #20103

Merged

geoand closed this as completed in #20103 Sep 29, 2021

quarkus-bot bot added this to the 2.4 - main milestone Sep 29, 2021

geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Injecting ConfigMapping in resteasy containerrequestfilter causes NoSuchElementException #18333

Injecting ConfigMapping in resteasy containerrequestfilter causes NoSuchElementException #18333

Postremus commented Jul 2, 2021

Postremus commented Jul 2, 2021

gsmet commented Jul 2, 2021

geoand commented Jul 2, 2021 •

edited

Loading

radcortez commented Jul 2, 2021

gsmet commented Sep 6, 2021

boev commented Mar 18, 2022 •

edited

Loading

radcortez commented Mar 18, 2022

boev commented Mar 21, 2022 •

edited

Loading

holly-cummins commented Feb 9, 2023

radcortez commented Feb 10, 2023

holly-cummins commented Feb 10, 2023

radcortez commented Feb 10, 2023

Injecting ConfigMapping in resteasy containerrequestfilter causes NoSuchElementException #18333

Injecting ConfigMapping in resteasy containerrequestfilter causes NoSuchElementException #18333

Comments

Postremus commented Jul 2, 2021

Describe the bug

Expected behavior

Actual behavior

To Reproduce

Configuration

Environment (please complete the following information):

Output of uname -a or ver

Output of java -version

Quarkus version or git rev

Build tool (ie. output of mvnw --version or gradlew --version)

Postremus commented Jul 2, 2021

gsmet commented Jul 2, 2021

geoand commented Jul 2, 2021 • edited Loading

radcortez commented Jul 2, 2021

gsmet commented Sep 6, 2021

boev commented Mar 18, 2022 • edited Loading

radcortez commented Mar 18, 2022

boev commented Mar 21, 2022 • edited Loading

holly-cummins commented Feb 9, 2023

radcortez commented Feb 10, 2023

holly-cummins commented Feb 10, 2023

radcortez commented Feb 10, 2023

Output of `uname -a` or `ver`

Output of `java -version`

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

geoand commented Jul 2, 2021 •

edited

Loading

boev commented Mar 18, 2022 •

edited

Loading

boev commented Mar 21, 2022 •

edited

Loading