Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus build docker images should emit warning when pom.xml have no "Container Image extensions" #17901

Closed
kafeltz opened this issue Jun 14, 2021 · 2 comments · Fixed by #23943
Assignees
Labels
area/config kind/enhancement New feature or request
Milestone

Comments

@kafeltz
Copy link

kafeltz commented Jun 14, 2021

Description

When doing ./mvnw clean package it does not emit any warning/error trying to create a docker image and/or pushing it.

It took me some hours to find out that I must put an Container Image extensions like this one:

<dependency>
    <groupId>io.quarkus</groupId>
    <artifactId>quarkus-container-image-docker</artifactId>
</dependency>

I know that info is writting in the guide: https://quarkus.pro/guides/container-image.html but would be nice an warning instead of "nothing" because I forgot that part and this would save people wasting time figuring this out.

Thx

@kafeltz kafeltz added the kind/enhancement New feature or request label Jun 14, 2021
@geoand
Copy link
Contributor

geoand commented Jun 15, 2021

@radcortez I wonder if we should also be emitting a warning at build time if a config property does not map to Quarkus Config object

@radcortez
Copy link
Member

We should be able to do it for build time as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants