Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus CLI does not display icons correctly #17876

Closed
ghost opened this issue Jun 12, 2021 · 19 comments · Fixed by #17955
Closed

Quarkus CLI does not display icons correctly #17876

ghost opened this issue Jun 12, 2021 · 19 comments · Fixed by #17955
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Jun 12, 2021

Describe the bug

When creating an app via Quarkus CLI the icons are not displayed as shown in the documentation.
In my terminal a white rectangle is shown instead.

Expected behavior

Icons are displayed correctly or if the terminal does not support this something else is used instead.

Actual behavior

Icons are not displayed correctly.

To Reproduce

Steps to reproduce the behavior:

  1. quarkus create app

Screenshots

quarkus-cli-missing-logos

Environment

OS: Linux
Shell: Bash
Terminal: Konsole (KDE, https://konsole.kde.org/)

@ghost ghost added the kind/bug Something isn't working label Jun 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 12, 2021

/cc @ebullient, @gsmet, @maxandersen

@quarkus-bot quarkus-bot bot added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Jun 12, 2021
@maxandersen
Copy link
Member

What os, shell and terminal are you using ?

@ghost
Copy link
Author

ghost commented Jun 12, 2021

OS: Linux
Shell: Bash
Terminal: Konsole (KDE, https://konsole.kde.org/)

@ghost
Copy link
Author

ghost commented Jun 12, 2021

And in xterm it looks like this :-)
quarkus-cli-xterm

@maxandersen
Copy link
Member

Does your font have icons normally ?

@ghost
Copy link
Author

ghost commented Jun 12, 2021

Simple icons yes, but not Emojis. Tried to use different fonts with emojis:

  • EmojiOne Color Font -> the icon for Maven is missing, only black & white
  • Noto Emoji Font -> only black & white
  • Twemoji Color Font -> only black & white

The problem is all of them are not suited to be used in a terminal (no fixed character width). And all of them are not colored but black & white.

@maxandersen
Copy link
Member

Just to check - I assume you have Same issue with using mvn create plugin which is the same code ?

@ghost
Copy link
Author

ghost commented Jun 13, 2021

Not sure what you mean. This does not display any icons/emojis, just an error message:
maven-create-plugin

@maxandersen
Copy link
Member

I mean the way we thus far use maven to create projects:

'''

mvn io.quarkus:quarkus-maven-plugin:1.13.7.Final:create
-DprojectGroupId=org.acme
-DprojectArtifactId=getting-started
-DclassName="org.acme.getting.started.GreetingResource"
-Dpath="/hello"
cd getting-started
'''

How does that render its output on your setup?

@ghost
Copy link
Author

ghost commented Jun 13, 2021

Then I see the following output:
quarkus-maven-tooling

Note that after installing the Emoji fonts I see at least some of the emojis (in black & white). Not sure if there exists another font pack that is missing to get the other emojis, too.

@ghost
Copy link
Author

ghost commented Jun 13, 2021

Finally made some progress!

gnome-terminal-quarks

This is with the Gnome Terminal. Furthermore I installed ONLY the Noto Color Emoji font.

The icon for Maven 🧰 is still not working here.

There is also a missing space for some icons. This seem to be exactly the ones that have the FE0F appended (to indicate colored icon). See here for an explanation: https://en.opensuse.org/Emoji.
For a list of emojis with code points to be able to avoid the FE0F see here: https://unicode.org/Public/emoji/12.0/emoji-test.txt

Maybe we could replace the icons that are making problems with similar ones?

  • Maven: 🧰 could be replaced by 💼 or 📦
  • Quarkus: 🗃️ could be replaced by 💎, 👑, 🚀 etc. :-)
  • Dockerfiles: 🛠️ could be replaced by 🐋 or 🐳
  • Maven-Wrapper: 🛠️ could be replaced by 🔨 or 🔧

The suggested icons all work fine here.

@maxandersen
Copy link
Member

make sense to choose better icons when available.

we do though expect users using "modern" terminals - sounds like your kconsole/xterm setup uses the absolute minimal terminal setup :)

@ghost
Copy link

ghost commented Jun 16, 2021

In WSL it looks the following:
quarkus-cli-wsl

The mentioned alternative Emojis from the comment above would all work in WSL out-of-the-box (only B&W here).

@ebullient ebullient added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins and removed area/cli Related to quarkus cli (not maven/gradle/etc.) labels Jun 16, 2021
@ebullient
Copy link
Member

The emojis are rendered w/in common code in devtools/codestarts...

@ebullient
Copy link
Member

To clarify, you're asking to work backwards and use older emojis that have a monichrome/unqualified equivalent?
Most of what you link recommended adding that suffix to ensure the color version was used (which would require it to be present)

@ebullient
Copy link
Member

Can you try w/ the PR?

@ghost
Copy link
Author

ghost commented Jun 16, 2021

Sure. Can you give a hint on what is the easiest way to build the CLI from the repo? Thanks!

@ghost
Copy link
Author

ghost commented Jun 16, 2021

@ebullient Never mind. Just built everything and then I was able to execute the CLI JAR.

The emojis look good now in the Gnome Terminal!

quarkus-cli-snapshot

@maxandersen
Copy link
Member

2021-06-17_00-50-38

here is it on osx in iterm2.

they are much less distinguishable but wsl usecase is quite a big crowd thus I reluctantly agree.

@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 18, 2021
@gsmet gsmet removed this from the 2.1 - main milestone Jun 21, 2021
@gsmet gsmet added this to the 2.0.0.Final milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants