-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some build items are missing in documentation #17770
Comments
/cc @maxandersen, @quarkusio/devtools |
/cc @gastaldi |
I want to work on this. |
I'd like to work on this, but it will be very helpful if you can give more instructions on which ones should be included here (besides the ones ending with "BuildItems.java") and how to find them? @knutwannheden |
Hi how do I link my pull request to this issue? I couldn't edit the "Linked issues" option there. #22011 @knutwannheden |
Sorry, this issue fell through the cracks. I think I'm a bit torn on nested build item classes, IMHO we shouldn't list in the config document, since it most likely it was created to be an implementation detail and used internally |
@gastaldi I couldn't find any other exceptions to this rule either. I don't know exactly when this tool runs, but I was naively assuming that it should be possible to let it either scan the Java class files (using some library) or even the files produced by the Quarkus APT itself to process all build items properly (similarly as for the |
I think this one is pretty much covered now. |
Describe the bug
The Jbang script generating the https://quarkus.io/guides/all-builditems documentation overview page currently only includes build items which are defined in source files ending in
BuildItem.java
(seequarkus/.github/quarkusbuilditemdoc.java
Line 96 in adf1beb
Capabilities
) or are defined as nested classes (e.g. in the processor class). As a result some build items are missing in the generated overview page.Expected behavior
All (public?) build items should be included in the generated overview page.
Actual behavior
See description.
The text was updated successfully, but these errors were encountered: