Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some build items are missing in documentation #17770

Closed
knutwannheden opened this issue Jun 8, 2021 · 8 comments
Closed

Some build items are missing in documentation #17770

knutwannheden opened this issue Jun 8, 2021 · 8 comments
Labels
area/jbang Issues related to when using jbang.dev with Quarkus good first issue Good for newcomers kind/enhancement New feature or request

Comments

@knutwannheden
Copy link
Contributor

Describe the bug

The Jbang script generating the https://quarkus.io/guides/all-builditems documentation overview page currently only includes build items which are defined in source files ending in BuildItem.java (see

if (file.toString().endsWith("BuildItem.java")) {
). There are however also build items which either don't adhere to this convention (e.g. Capabilities) or are defined as nested classes (e.g. in the processor class). As a result some build items are missing in the generated overview page.

Expected behavior

All (public?) build items should be included in the generated overview page.

Actual behavior

See description.

@knutwannheden knutwannheden added the kind/bug Something isn't working label Jun 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

/cc @maxandersen, @quarkusio/devtools

@quarkus-bot quarkus-bot bot added the area/jbang Issues related to when using jbang.dev with Quarkus label Jun 8, 2021
@gsmet
Copy link
Member

gsmet commented Jun 9, 2021

/cc @gastaldi

@gastaldi gastaldi added the good first issue Good for newcomers label Jun 9, 2021
@gsmet gsmet added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jun 10, 2021
@shoebxsiddiqui
Copy link

I want to work on this.

@delongmeng-aws
Copy link

I'd like to work on this, but it will be very helpful if you can give more instructions on which ones should be included here (besides the ones ending with "BuildItems.java") and how to find them? @knutwannheden

@delongmeng-aws
Copy link

Hi how do I link my pull request to this issue? I couldn't edit the "Linked issues" option there. #22011 @knutwannheden

@gastaldi
Copy link
Contributor

gastaldi commented Dec 9, 2021

Sorry, this issue fell through the cracks. I think Capabilities is an exception to the rule, we can hardcode that in the generator. Other build items like ProcessInheritIODisableare being deprecated in favor of the BuildItem suffix (see #22081).

I'm a bit torn on nested build item classes, IMHO we shouldn't list in the config document, since it most likely it was created to be an implementation detail and used internally

@knutwannheden
Copy link
Contributor Author

@gastaldi I couldn't find any other exceptions to this rule either. I don't know exactly when this tool runs, but I was naively assuming that it should be possible to let it either scan the Java class files (using some library) or even the files produced by the Quarkus APT itself to process all build items properly (similarly as for the @ConfigRoot annotations for the config reference). But if indeed some build items are to be regarded as internal, this would require some other explicit mechanism (like a naming convention or some annotation attribute) to declare a build item as internal.

@gsmet
Copy link
Member

gsmet commented May 23, 2022

I think this one is pretty much covered now.

@gsmet gsmet closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jbang Issues related to when using jbang.dev with Quarkus good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants