Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusIntegrationTest on java jar, should support Jacoco #17760

Closed
bdevreugd-vialis opened this issue Jun 8, 2021 · 2 comments · Fixed by #17677
Closed

QuarkusIntegrationTest on java jar, should support Jacoco #17760

bdevreugd-vialis opened this issue Jun 8, 2021 · 2 comments · Fixed by #17677

Comments

@bdevreugd-vialis
Copy link
Contributor

In our CI we first do a simple mvn verify run with jacoco enabled, so we can get proper test coverage results.

With QuarkusIntegrationTest, the jar is obviously run on a separate JVM, which doesn't have the jacoco java-agent.

args.add("-jar");
args.add(jarPath.toAbsolutePath().toString());

Would it be possible to pass the argLine value set by the jacoco-maven-plugin to the created jvm? That way Jacoco would work fine for integration tests that simply use the jar.

Obviously it won't work on docker/native, just on the java one.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 8, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Jun 8, 2021

#17677 will fix this

@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 9, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants