Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertx Redis client configuration via Quarkus properties #17673

Closed
pokusak opened this issue Jun 3, 2021 · 5 comments
Closed

Vertx Redis client configuration via Quarkus properties #17673

pokusak opened this issue Jun 3, 2021 · 5 comments
Assignees
Labels
area/redis good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@pokusak
Copy link

pokusak commented Jun 3, 2021

Description

Quarkus 2.x uses Vertx 4.x which provides Redis client which provides more features than exposed via Quarkus configuration options. It would be great to configure features like TLS or AUTH (possibly others) directly via Quarkus configuraiton properties to avoid manual configuration of Redis client used by Vertx used by Quarkus.

Functionality is already provided by existing code as discussed in #13161. This enhancement is only about configuration propagation from Quarkus to Vertx Redis client.

@pokusak pokusak added the kind/enhancement New feature or request label Jun 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021

/cc @cescoffier, @gsmet, @machi1990

@machi1990
Copy link
Member

Thanks @pokusak for opening the issue. It should be relative straight forward, do you want to take a look at it?

@machi1990 machi1990 added the good first issue Good for newcomers label Jun 3, 2021
@antoniodvr
Copy link
Contributor

@machi1990 I can take it!

@machi1990
Copy link
Member

@antoniodvr thanks. Consider the issue yours, ping me in case of anything or you want an early review /feedback on the PR.

@cescoffier
Copy link
Member

Fixed by #17714

@gsmet gsmet added this to the 2.0.0.Final milestone Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants