Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry - VertxHttpClient doesn't have his own span #16507

Closed
pjgg opened this issue Apr 14, 2021 · 3 comments
Closed

Opentelemetry - VertxHttpClient doesn't have his own span #16507

pjgg opened this issue Apr 14, 2021 · 3 comments
Assignees
Labels
area/tracing kind/bug Something isn't working
Milestone

Comments

@pjgg
Copy link
Contributor

pjgg commented Apr 14, 2021

Describe the bug

I am working with opentelemetry extensions over a Quarkus application, Reactive routes, and vert.x HttpClient:

       <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-opentelemetry</artifactId>
        </dependency>

        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-opentelemetry-exporter-jaeger</artifactId>
        </dependency>

        <dependency>
            <groupId>io.smallrye.reactive</groupId>
            <artifactId>smallrye-mutiny-vertx-web-client</artifactId>
        </dependency>

Based on this doc I expected that If I have an HttpClient behind an endpoint, I will have two spans with the same traceId. The first span represents the endpoint and the second the HttpClient request. But I am getting just one Span per traceId (we are not recording HTTP requests)

You have a reproducer here.

@pjgg pjgg added the kind/bug Something isn't working label Apr 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 14, 2021

/cc @kenfinnigan

@kenfinnigan
Copy link
Member

Not all usages of OpenTelemetry have been tested/verified at present.

Right now I expect RESTEasy Classic, REST Client, and Reactive Messaging with Kafka to work. Other extensions may "work", but there are no guarantees at present.

In addition, the existing extensions in 1.x will likely change significantly for the 2.x/main stream

@kenfinnigan
Copy link
Member

I verified this works with the 2.0 branch.

@kenfinnigan kenfinnigan added this to the 2.0.0.Final milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants