Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a parent pom for external extensions #1594

Closed
danielpetisme opened this issue Mar 20, 2019 · 3 comments
Closed

Propose a parent pom for external extensions #1594

danielpetisme opened this issue Mar 20, 2019 · 3 comments
Assignees
Labels
kind/new-feature pinned Issue will never be marked as stale triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@danielpetisme
Copy link
Contributor

danielpetisme commented Mar 20, 2019

Currently, the extensions are embedded into the main Quarkus repository thus use the internal build-parent pom.xml.
To permits 3rd parties to develop their own extensions, it would be great to propose a public quarkus-extension-parent pom.

https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Extensions/near/161188290

@ppalaga
Copy link
Contributor

ppalaga commented Aug 6, 2019

I proposed a basic parent for third party extensions in #3427 the commit: ppalaga@5120227

However, when we start refactoring the hierarchy, @aloubyansky would like to solve more than this single problem #3427 (comment)

This is basically the same approach I was investigating. I was just thinking it could be organized slightly differently, e.g.

build-parent/
|- application/
|  `- pom.xml (parent for apps built on Quarkus core, flattened)
|- extension/
|  `- pom.xml (parent for extensions built on Quarkus core, probably has application/pom.xml as its parent, flattened)
`- internal/
   `- pom.xml (Quarkus core build parent pom, has extension/pom.xml as its parent).

However, before actually applying this kind of change, it'd be a good idea to announce/discuss it on the dev list.

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you!
We are doing this automatically to ensure out-of-date issues does not stay around indefinitely.
If you believe this issue is still relevant please put a comment on it on why and if it truly needs to stay request or add 'pinned' label.

@stale stale bot added the stale label Nov 13, 2019
@maxandersen maxandersen removed the stale label Nov 13, 2019
@gsmet gsmet added the pinned Issue will never be marked as stale label Nov 13, 2019
@danielpetisme
Copy link
Contributor Author

@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new-feature pinned Issue will never be marked as stale triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants