Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OIDC client code to retry if the request failed with Connection Was Closed #15933

Closed
sberyozkin opened this issue Mar 22, 2021 · 1 comment · Fixed by #16060
Closed
Assignees
Labels
area/oidc kind/enhancement New feature or request
Milestone

Comments

@sberyozkin
Copy link
Member

Description

It affects both quarkus-oidc and quarkus-oidc-client - if the connection error has happened after the initial connection was established, for ex, the connection was dropped, then, as recommended by Clement, it makes sense to retry.

Implementation ideas

I've seen this Connection was closed only once, today, so it is quite rare - but for the moment I'll just add say 3 retries with a 1/2 sec delay between the retries, which should be sufficient - later on we can also configure it better - but for now I'd like to avoid users configuring for ex a 5 secs delay between the retries or retry for 1 min etc
CC @cescoffier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
2 participants