Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picocli example app readme is incorrect #15758

Closed
emmanuelbernard opened this issue Mar 16, 2021 · 7 comments · Fixed by #15770
Closed

Picocli example app readme is incorrect #15758

emmanuelbernard opened this issue Mar 16, 2021 · 7 comments · Fixed by #15770
Assignees
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts kind/bug Something isn't working
Milestone

Comments

@emmanuelbernard
Copy link
Member

Describe the bug

Create app from code.quarkus.io with picocli selected and with Gradle: the readme instructions are incorrect and with bad error report.

Expected behavior

Readme should show proper Gradle syntax

Actual behavior

Gradle syntax is incorrect, it should be

## incorrect one  (both use of -D and use of help)
./gradlew quarkusDev -Dquarkus.args=='help'

## correct one
./gradlew quarkusDev --quarkus-args='-h'

To Reproduce

Create app from code.quarkus.io with picocli selected and with Gradle.

Quarkus version or git rev

1.12.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

gradlew

@emmanuelbernard emmanuelbernard added the kind/bug Something isn't working label Mar 16, 2021
@emmanuelbernard
Copy link
Member Author

@ia3andy is that for you?

@emmanuelbernard emmanuelbernard added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Mar 16, 2021
@maxandersen
Copy link
Member

a bit surprised - @aloubyansky shouldn't -D work for gradle plugin too here?

@ia3andy
Copy link
Contributor

ia3andy commented Mar 16, 2021

Good catch! I'll fix it..

@ia3andy ia3andy self-assigned this Mar 16, 2021
@maxandersen
Copy link
Member

Good catch! I'll fix it..

but shouldn't -D not work too?

@ia3andy
Copy link
Contributor

ia3andy commented Mar 16, 2021

@maxandersen I have no idea :)

@ia3andy
Copy link
Contributor

ia3andy commented Mar 16, 2021

@maxandersen ok you are right it should work with (

./gradlew quarkusDev -Dquarkus.args='hello --first-name=andy'

I think it's a quarkus core bug with gradle and command mode.

Here is a sample reproducer https://github.com/ia3andy/try-picocli-gradle

cc @stuartwdouglas @glefloch

@ia3andy
Copy link
Contributor

ia3andy commented Mar 16, 2021

ahh it works with:

./gradlew quarkusDev --quarkus-args='hello --first-name=andy'

I found this in the template: https://github.com/quarkusio/quarkus/blob/main/devtools/platform-descriptor-json/src/main/resources/codestarts/quarkus/examples/picocli-example/base/README.tpl.qute.md

Which I should fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/codestarts kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants