Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help message with Quarkus CLI mentions a different executable #15644

Closed
gastaldi opened this issue Mar 11, 2021 · 6 comments
Closed

Help message with Quarkus CLI mentions a different executable #15644

gastaldi opened this issue Mar 11, 2021 · 6 comments
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) good first issue Good for newcomers kind/bug Something isn't working

Comments

@gastaldi
Copy link
Contributor

Describe the bug
Running qs --help (installed through jbang app install --name qs cli@quarkusio) shows that the executable name is quarkus in the usage section

/ ᐅ qs --help
[jbang] Resolving dependencies...
[jbang]     Resolving io.quarkus:quarkus-cli:1.11.3.Final:runner...Done
[jbang] Dependencies resolved
Usage: quarkus [-ehV] [--verbose] [COMMAND]
  -e, --errors    Produce execution error messages.
  -h, --help      Show this help message and exit.
  -V, --version   Print version information and exit.
      --verbose   Verbose mode.
Commands:
  build         Build your quarkus project
  clean         Clean current project
  create        Create a new quarkus project.
  create-jbang  Create a new quarkus jbang project.
  list          List installed (default) or installable extensions.
  add           Add extension(s) to current project.
  remove, rm    Remove an extension from this project.
  dev           Execute project in live coding dev mode

Expected behavior
It should display qs

Actual behavior
It shows quarkus as the executable name

To Reproduce

Steps to reproduce the behavior:

  1. Install JBang: sdk install jbang
  2. Install Quarkus Cli: jbang app install --name qs cli@quarkusio
  3. Run qs --help
@gastaldi gastaldi added the kind/bug Something isn't working label Mar 11, 2021
@quarkus-bot quarkus-bot bot added the area/jbang Issues related to when using jbang.dev with Quarkus label Mar 11, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 11, 2021

/cc @maxandersen, @quarkusio/devtools

@gastaldi gastaldi added the good first issue Good for newcomers label Mar 11, 2021
@abidahmadq
Copy link

I can start working on this. I am a new contributor so if anyone can point me into the right direction it would be great !

@gastaldi
Copy link
Contributor Author

I think it's a matter of changing the command name in

@CommandLine.Command(name = "quarkus", aliases = {

and probably removing the aliases field, since they would be the same

@abidahmadq
Copy link

Lol looks like it was fixed :D

@aadityasinha-dotcom
Copy link

Can I work on this issue?

@gastaldi
Copy link
Contributor Author

gastaldi commented Mar 20, 2021

Sorry, but this was already fixed in #15747. Closing

@maxandersen maxandersen added area/cli Related to quarkus cli (not maven/gradle/etc.) and removed area/jbang Issues related to when using jbang.dev with Quarkus labels Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants