Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of vertx-cache temporary directories #15566

Closed
rsvoboda opened this issue Mar 9, 2021 · 3 comments · Fixed by #15541
Closed

Cleanup of vertx-cache temporary directories #15566

rsvoboda opened this issue Mar 9, 2021 · 3 comments · Fixed by #15541
Labels
area/vertx kind/enhancement New feature or request

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Mar 9, 2021

Introduce enhancement to clean vertx-cache temporary directories

Highlighted during review of #15541 (review)

The previous approach was not deleting the directory either, but it is better to do the cleanup if we have created the directory.

We won't clean if it's a directory set by the user (because it would reuse it during the next execution, and so would allow avoiding copying files over).

@rsvoboda rsvoboda added the kind/enhancement New feature or request label Mar 9, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 9, 2021

/cc @gwenneg

@rsvoboda
Copy link
Member Author

rsvoboda commented Mar 9, 2021

/cc @cescoffier

@cescoffier
Copy link
Member

I did it as part of #15541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertx kind/enhancement New feature or request
Projects
None yet
2 participants