Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - ? instead of codestarts icons when generating project #14219

Closed
rsvoboda opened this issue Jan 11, 2021 · 7 comments · Fixed by #14722
Closed

Windows - ? instead of codestarts icons when generating project #14219

rsvoboda opened this issue Jan 11, 2021 · 7 comments · Fixed by #14722
Labels
area/codestarts env/windows Impacts Windows machines good first issue Good for newcomers kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

Running https://quarkus.io/guides/getting-started#bootstrapping-the-project on Windows 10

There are ? instead of codestarts icons when generating project, tried with cmd and poweshell

Screenshot 2021-01-11 11 20 08

Screenshot 2021-01-11 11 21 35

Expected to see something like this:
Screenshot 2021-01-11 at 11 50 53

@rsvoboda rsvoboda added the kind/bug Something isn't working label Jan 11, 2021
@ghost ghost added area/codestarts env/windows Impacts Windows machines labels Jan 11, 2021
@ghost
Copy link

ghost commented Jan 11, 2021

/cc @ia3andy, @quarkusio/devtools

@ia3andy
Copy link
Contributor

ia3andy commented Jan 11, 2021

@rsvoboda I believe that unicode is not by default on PowerShell, could you try what's suggested in that answer?
https://stackoverflow.com/a/49481797

If this solution works, I don't know if we should switch to bullets for Windows or keep it and let the user enable it or not?

@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 11, 2021

I tried https://stackoverflow.com/questions/57131654/using-utf-8-encoding-chcp-65001-in-command-prompt-windows-powershell-window/57134096#57134096 but without luck

A) My old Windows 10 machine without service packs installed - I don't even have that set the system locale (language for non-Unicode programs) to UTF-8 option available
B) My wife's Windows 10 machine - settings is available, selected it, restarted the system but still see ?, tried with both cmd and powershell

@ia3andy ia3andy added the good first issue Good for newcomers label Jan 11, 2021
@ia3andy
Copy link
Contributor

ia3andy commented Jan 11, 2021

Ok, so we need a patch to use bullets on Windows systems.

@imshuv
Copy link

imshuv commented Jan 20, 2021

I want to work on this ,I would be extremely thankful if someone could guide me on how to get started with this?

@ejba
Copy link
Contributor

ejba commented Jan 24, 2021

Someone corrects me if I am wrong.

  • Jump to independent-projects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/core/CodestartProjectGeneration.java
  • Refactor L51 with the following algorithm:
    • Get OS name (e.g.System.getProperty("os.name"))
    • if the name contains "win" then use bullets, otherwise use CodestartType.getIcon()

@ia3andy
Copy link
Contributor

ia3andy commented Jan 25, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts env/windows Impacts Windows machines good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants