Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvn add-extension in sub-module shouldn't add dependencyManagement #14164

Closed
gunnarmorling opened this issue Jan 7, 2021 · 4 comments · Fixed by #16290
Closed

mvn add-extension in sub-module shouldn't add dependencyManagement #14164

gunnarmorling opened this issue Jan 7, 2021 · 4 comments · Fixed by #16290
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working
Milestone

Comments

@gunnarmorling
Copy link
Contributor

I call mvn add-extension for a sub-module of a Maven multi-module project. This adds a dependencyManagement block to that module's POM with the Quarkus BOM, although that's already present in the parent. This also removes the reference to the parent POM (<relativePath>../pom.xml</relativePath> gets removed).

@gunnarmorling gunnarmorling added the kind/bug Something isn't working label Jan 7, 2021
@ghost ghost added the triage/needs-triage label Jan 7, 2021
@famod
Copy link
Member

famod commented Jan 15, 2021

Thanks for reporting!

I haven't reproduced it yet but looking at the code there does not seem to be a parent check.

Btw, ../pom.xml is the default for relativePath and can thus be omitted. But I agree that the plugin should not mess with it.

I'll have a look in the next days.

/cc @aloubyansky

@famod famod added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins and removed triage/needs-triage labels Jan 15, 2021
@famod famod self-assigned this Jan 15, 2021
@aloubyansky
Copy link
Member

@ia3andy fyi

@famod
Copy link
Member

famod commented Apr 6, 2021

Should be fixed by the PR for #16264.

@aloubyansky
Copy link
Member

This should be fixed by #16290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working
Projects
None yet
3 participants