Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why LOG level may be different to the configured level in CI builds #14140

Closed
sberyozkin opened this issue Jan 6, 2021 · 7 comments
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/question Further information is requested

Comments

@sberyozkin
Copy link
Member

Description
integration-tests/bouncycastle-fips-jsse test has this configuration:

quarkus.log.category."org.bouncycastle.jsse".level=TRACE

When I run this test locally both the console and file logs are reported at the trace level in JVM mode. In CI I saw a message like
"org.bouncycastle.jsse".level is configured at the level below the required INFO, promoting it to INFO - so I had to disable checking the log for that test.

@sberyozkin sberyozkin added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jan 6, 2021
@gsmet
Copy link
Member

gsmet commented Jan 6, 2021

It might be due to the new min-level feature: #13376 .

/cc @galderz

@sberyozkin
Copy link
Member Author

@gsmet Interesting, thanks, I'll give it a try in another PR :-)

@sberyozkin
Copy link
Member Author

Specifically I'll try to re-enable checking the log in bouncycastle-fips-jsse (this one runs in JVM mode for now) and update the way it is checked in bouncycastle-jsse (runs in JVM and native modes - in JVM both client and server TLS records are checked, in native - only server as client ones were not captured - I'll try to catch the client records in the native mode too)

@sberyozkin
Copy link
Member Author

I've started with #14163.

@galderz Hi, quick question - why does integration-tests/oidc-client which also has a TRACE enabled successfully detects TRACE-level logging without min-level, while integration-tests/bouncycastle-fips-jsse fails without min-level, something I've now also verified locally ? Can it be related to the fact that integration-tests/oidc-client traces the quarkus-oidc-client/runtime/.../OidcClientImpl.class (so this class is native to the extension) while integration-tests/bouncycastle-fips-jsse traces a 3rd party library ?

@sberyozkin
Copy link
Member Author

sberyozkin commented Jan 7, 2021

@galderz integration-tests/bouncycastle-jsse also works without min-level but it deals with a 3rd party library traces.

I'm not sure - the documentation is clear that min-level allows to optimize and remove some dead code related to the trace level, but it looks non-intuitive to me, having to set TRACE twice. I guess no one is using this level in production

@sberyozkin
Copy link
Member Author

@Galder - oh, sorry, you've already fixed integration-tests/bouncycastle-jsse, thanks :-)

@sberyozkin
Copy link
Member Author

I'm going to close this one now, in the native mode, bouncycastle-jsse can still not capture the client records, but I'm not really worried about it as the MTLS test itself passes and it is not really related I think to the min-level. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants