Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some URLs without HTTPS #13888

Closed
LuccaPrado opened this issue Dec 15, 2020 · 6 comments
Closed

Some URLs without HTTPS #13888

LuccaPrado opened this issue Dec 15, 2020 · 6 comments
Labels
good first issue Good for newcomers kind/enhancement New feature or request triage/needs-triage
Milestone
1.11.0.Beta2

Comments

@LuccaPrado
Copy link
Contributor

Description
I've noticed that some urls on quarkus, like apache license 2.0, w3.org xml schema and liquibase schema definitions (and others may be too) are still using http instead of https.

Implementation ideas
Change the http urls to https when exists and its possible.
@LuccaPrado LuccaPrado added the kind/enhancement New feature or request label Dec 15, 2020
@ghost ghost added the triage/needs-triage label Dec 15, 2020
@geoand geoand added the good first issue Good for newcomers label Dec 15, 2020
@geoand
Copy link
Contributor

geoand commented Dec 15, 2020

Hi!

Would you like to provide a Pull Request addressing this issue?

@LuccaPrado
Copy link
Contributor Author

I'll create a PR with that today!

@LuccaPrado
Copy link
Contributor Author

@geoand I just don't know if on xml xmls this could be a problem. (as I don't understand the use of this url on it).

For example on file:
https://github.com/quarkusio/quarkus/blob/b27b4cc998bff4709bc09fd3aa0e752e1a6002f2/build-parent/pom.xml
On line 2

@geoand
Copy link
Contributor

geoand commented Dec 15, 2020

I would leave those out TBH

@LuccaPrado LuccaPrado mentioned this issue Dec 16, 2020
Merged
@LuccaPrado
Copy link
Contributor Author

I Guess that with my PR #13911 we can close this issue (as the other urls are in xmlNamespaces)

@geoand
Copy link
Contributor

geoand commented Dec 17, 2020

Closed by #13911

@geoand geoand closed this as completed Dec 17, 2020
@geoand geoand added this to the 1.11 - master milestone Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement New feature or request triage/needs-triage
Projects
None yet
Milestone
1.11.0.Beta2
Development

No branches or pull requests
2 participants
@geoand @LuccaPrado