Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleScheduler: pause doesn't work #13512

Closed
RustamSultansoy opened this issue Nov 27, 2020 · 3 comments · Fixed by #13532
Closed

SimpleScheduler: pause doesn't work #13512

RustamSultansoy opened this issue Nov 27, 2020 · 3 comments · Fixed by #13532
Labels
area/scheduler kind/bug Something isn't working
Milestone

Comments

@RustamSultansoy
Copy link

Describe the bug
When you try to inject SimpleScheduler and then call SimpleScheduler::pause nothing happens.

Expected behavior
Scheduled jobs should be paused

Actual behavior
Nothing happens

To Reproduce
Add some method annotated by @scheduled
Then try to pause scheduler using SimpleScheduler::pause method.

Screenshot 2020-11-27 at 12 26 40

looks like bug is here.
@RustamSultansoy RustamSultansoy added the kind/bug Something isn't working label Nov 27, 2020
@ghost ghost added the area/scheduler label Nov 27, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

/cc @mkouba

@mkouba
Copy link
Contributor

mkouba commented Nov 27, 2020

Uf, that's a stupid bug :-(. @RustamSultansoy Would you care to send a PR? The fix is very straightforward. A test could be a little bit more challenging ;-)

@RustamSultansoy
Copy link
Author

@mkouba yeap, will send a pull request from my personal account later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduler kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants