Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hibernate ORM's JTAPlatform implementation is leaking a reference to its registry #12976

Closed
Sanne opened this issue Oct 27, 2020 · 2 comments · Fixed by #12977
Closed

Hibernate ORM's JTAPlatform implementation is leaking a reference to its registry #12976

Sanne opened this issue Oct 27, 2020 · 2 comments · Fixed by #12977
Assignees
@Sanne
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Milestone
1.10.0.CR1

Comments

@Sanne
Copy link
Member

Sanne commented Oct 27, 2020

Describe the bug
The QuarkusJtaPlatform implementation is extending a base class from upstream ORM which maks it a bad choice for also being used as a static singleton.
In particular this leads the classloader to hold on to a reference of the ORM ServiceRegistry, in turn leaking a significant amount of memory.

We can easily fix it to be a real stateless JtaPlatform, as we don't need the registry.
@Sanne Sanne added the kind/bug Something isn't working label Oct 27, 2020
@Sanne Sanne self-assigned this Oct 27, 2020
@quarkusbot quarkusbot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 27, 2020
@quarkusbot
Copy link

/cc @gsmet

@Sanne Sanne mentioned this issue Oct 27, 2020
Merged
@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
@gsmet
Copy link
Member

gsmet commented Oct 27, 2020

I don't feel comfortable backporting this. Better keep this for 1.10 with potential other improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sanne Sanne

Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bug Something isn't working
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging a pull request may close this issue.

Reimplement the QuarkusJTAPlatform to avoid leaking the ORM registry Sanne/quarkus
3 participants
@Sanne @gsmet @quarkusbot