-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven plugin should be able to create a new Quarkus module when there is a root pom.xml file #12829
Comments
/cc @quarkusio/devtools |
Hi, I am working on this issue. Covered most of the parts:
I only checked existence of pom.xml file so it already assumes you are in a maven project. Should I be worried about gradle side of things ? |
I don't know if the Quarkus team wants both Maven and Gradle to have the same set of functionalities. @quarkusbot added the "area/maven" label, so I suppose it's Maven only ;o) |
maven and gradle should aim for same set of functionallities - the bot added area/maven because you only mentioned maven in your title ;) |
@maxandersen I thought the bot was a clever bot ;o) |
I will try to make required adjustments to my PR #12916 |
@ghokun feel free to open a separate PR for Gradle in case that's what you meant. Whatever you prefer. And thanks! |
Description
This issue is the follows up of a Zulip discusson[1]. Today, if you use the Maven plugin to create a new project (
mvn quarkus-maven-plugin:create
) and that there is a rootpom.xml
file, it errors[2]:Instead it should create the project, and add a module into the
<modules>
section. In some use-cases, you can have apom.xml
at the root of several non-Quarkus modules. And from this root, you want to create several Quarkus modules. Having this feature would allow creating Quarkus modules in existing Maven projects with sub-modules.[1] https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Forcing.20Maven.20plugin.20to.20create.20with.20existing.20pom.2Exml
[2] https://github.com/quarkusio/quarkus/blob/master/devtools/maven/src/main/java/io/quarkus/maven/CreateProjectMojo.java#L166
The text was updated successfully, but these errors were encountered: