Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mvn quarkus:dev" workspace discovery should respect default maven profiles #12715

Closed
ge0ffrey opened this issue Oct 14, 2020 · 4 comments · Fixed by #15342
Closed

"mvn quarkus:dev" workspace discovery should respect default maven profiles #12715

ge0ffrey opened this issue Oct 14, 2020 · 4 comments · Fixed by #15342
Assignees
Labels
area/bootstrap area/devmode area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/bug Something isn't working
Milestone

Comments

@ge0ffrey
Copy link
Contributor

ge0ffrey commented Oct 14, 2020

See second part of discussion here:
https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/ClassLoading.20error.20in.20hot.20deploy

In optaplanner 7.x, the quarkus-school-timetabling-quickstart's "mvn quarkus:dev" was failling because the optaplanner-parent has a maven module that includes the optaplanner-quarkus-integration - and that maven profile is on by default - but Quarkus ignores maven profiles.

@aloubyansky

@ge0ffrey ge0ffrey added the kind/bug Something isn't working label Oct 14, 2020
@aloubyansky aloubyansky added area/bootstrap area/devmode area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Oct 14, 2020
@quarkusbot
Copy link

/cc @quarkusio/devtools

@aloubyansky
Copy link
Member

#15342 introduced a config option to enable Quarkus workspace initialization based on effective POMs instead of the "raw" ones, which can be enabled by setting system property quarkus.bootstrap.effective-model-builder to true (e.g. in the surefire and/or quarkus maven plugin config).
The option is not enabled by default because effective POMs take significantly more time to resolve. Which depending on the number of modules in the project and the number of tests, may significantly increase testing time.
Until we find a more efficient alternative though, projects that require it, should enable this option.

@ge0ffrey
Copy link
Contributor Author

ge0ffrey commented May 6, 2021

Interesting, thank your for creating this @aloubyansky

How will users know this system property exists? I presume they'll run into the issue and hopefully google the right keywords to end up on a docs page that describes to use quarkus.bootstrap.effective-model-builder?

@aloubyansky
Copy link
Member

@ge0ffrey I've added the available options to the end of the maven-tooling guide in this PR #17351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap area/devmode area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/bug Something isn't working
Projects
None yet
3 participants