Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenShift route configuration #12630

Closed
gsmet opened this issue Oct 9, 2020 · 3 comments · Fixed by #13068
Closed

Improve OpenShift route configuration #12630

gsmet opened this issue Oct 9, 2020 · 3 comments · Fixed by #13068
Labels
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Oct 9, 2020

Notes from a Zulip discussion:

Having apparently unrelated config properties is an issue IMHO. I would rather have a route. config group with everything there.

Also:

  • I couldn't find a way to make the route secure (and I would make it the default as it seems more sensible?)
  • I think we should have route-specific annotations in the route. config group
  • I had a weird error message because a route was already configured with another host name and the host name is immutable, maybe we could improve that

Something like:

...route.expose =
...route.host =
...route.annotations."value" =
...route.secure =

Also I don't know if it makes sense to allow to define several routes? Maybe it's not worth it?

@gsmet gsmet added the kind/enhancement New feature or request label Oct 9, 2020
@gsmet
Copy link
Member Author

gsmet commented Oct 9, 2020

/cc @iocanel @geoand

@geoand
Copy link
Contributor

geoand commented Oct 9, 2020

+1 for moving all the relevant Route config into a dedicated root

Also I don't know if it makes sense to allow to define several routes? Maybe it's not worth it?

I doubt it's worth it TBH

@quarkusbot
Copy link

/cc @geoand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants