Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set main version to 999-SNAPSHOT #1212

Closed
cescoffier opened this issue Mar 5, 2019 · 9 comments
Closed

Set main version to 999-SNAPSHOT #1212

cescoffier opened this issue Mar 5, 2019 · 9 comments
Assignees
Milestone

Comments

@cescoffier
Copy link
Member

No description provided.

@gsmet
Copy link
Member

gsmet commented Mar 5, 2019

Do we really want to do that?

I mean in all the projects I know, we push the next version as a SNAPSHOT. Couldn't it be part of the release process to set the next version?

@cescoffier
Copy link
Member Author

It's actually very tricky as conflicts may happen if something touches the pom.xml while the release process is in progress.

Yes the conflict can be managed if the release is cut manually, but we want a fully automated release process, and in this case, it can be tricky.

@gsmet
Copy link
Member

gsmet commented Mar 5, 2019

For Hibernate projects, we have a fully automated process, it just takes the next version as input.

Frankly, this 999-SNAPSHOT is ugly and I don't think it's a good idea.

@cescoffier
Copy link
Member Author

How do you deal with conflicts?

@cescoffier
Copy link
Member Author

it's actually the mechanism we are using right now.

@dmlloyd
Copy link
Member

dmlloyd commented Mar 5, 2019

The rationale is that "999-SNAPSHOT" is better than "1.0.0.Alpha1-SNAPSHOT" especially in light of the fact that we'll never release a "1.0.0.Alpha1". We don't want to bother updating master every time there is a new tag, and we especially don't want to start doing so only after we've passed "1.0.0" because that's just silly.

@gsmet
Copy link
Member

gsmet commented Mar 5, 2019

This is automatically done via the Maven release plugin. The only issue I see would be with the Quickstarts but it could be easily scripted as we just have to change the quarkus.version.

I mean all the other Open Source projects I know are not doing that, it really is a bad practice IMHO.

@dmlloyd
Copy link
Member

dmlloyd commented Mar 5, 2019

Updating the head version after every release? Yes that's a bad practice because it creates merge conflicts pointlessly.

@cescoffier
Copy link
Member Author

PR: #1256

@stuartwdouglas stuartwdouglas added this to the 0.11.0 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants