Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual extensions to contribute codestarts #11221

Closed
maxandersen opened this issue Aug 5, 2020 · 11 comments
Closed

Allow individual extensions to contribute codestarts #11221

maxandersen opened this issue Aug 5, 2020 · 11 comments
Assignees

Comments

@maxandersen
Copy link
Member

Ability for individual extensions to contribute a codestart.

Idea is to have an additional artifact (i.e. codestarts) similar to how extension has a runtime and deployment artifact.

Will be added when the codestarts structure have matured in platform.

Part of #8134

@quarkusbot
Copy link

/cc @quarkusio/devtools, @ia3andy

@ia3andy ia3andy self-assigned this Jan 27, 2021
@ia3andy
Copy link
Contributor

ia3andy commented Jan 27, 2021

@aloubyansky would your new changes in the API affect this? Can I still start from the branch you created a few month ago (I think this one: https://github.com/aloubyansky/quarkus/tree/codestart-artifacts)?

@ia3andy
Copy link
Contributor

ia3andy commented Jan 27, 2021

This issue is also related to #11153 providing the testing library for extension codestarts.

@aloubyansky
Copy link
Member

If it is adding a codestart resource loader of some sort to Extension then yes, it will conflict. A codestart artifact coords should be added to the metadata in the descriptor and collected from there. I have decoupled the "Platform descriptor" from resource loaders. There could still be another class gathering them together of course.

@aloubyansky
Copy link
Member

@ia3andy given that codestarts artifacts referenced from the extension metadata are now added to the codestarts resource loader, do you still want to keep this one open?

@ia3andy
Copy link
Contributor

ia3andy commented Mar 30, 2021

@aloubyansky Let's say this issue is done when we have a working Quarkiverse extension with an extension codestart with testing.

@ia3andy ia3andy closed this as completed Oct 15, 2021
@tarilabs
Copy link
Contributor

@ia3andy @aloubyansky hi, if I understand correctly, I can follow the above guide now to create a Codestart also for platform's extensions such as Kogito; for example, in order to have for https://quarkus.io/guides/kogito-dmn also the airplane icon when selecting the extension in https://code.quarkus.redhat.com, is my understanding correct please?

/cc @danielezonca

@ia3andy
Copy link
Contributor

ia3andy commented Oct 15, 2021

@tarilabs yes, the airplane icon will soon (2.2) be replaced by the [code] tag like on https://code.quarkus.io/. But it works the same.

Also, extension codestarts should not contain business/example logic, but initial/hello code to start developing from. Is DMN fitting this? from a quick look at the quickstart, it seems it does, a few extra resources files right?

@tarilabs
Copy link
Contributor

@ia3andy thank you for feedback, re:

extension codestarts should not contain business/example logic, but initial/hello code to start developing from. Is DMN fitting this? from a quick look at the quickstart, it seems it does, a few extra resources files right?

any Kogito extension deals with expressing business logic with DMN, DRL, etc resource assets, so the moment I drop a DMN resource it will contain some form of logic anyway. I would like for the Codestart to have this "logic" veeery trivial as described here

That's a DMN-hello world kind of example, from my perspective.

The reason I'm asking, is that I got on my laps a PM request for a Codestart (in addition to the exiting Quickstart which is more evolved) with a simple DMN example, and I believe that fits. As I noticed this github issue is resolved, I wanted to start working on that request I received.

I will proceed in this way unless there are outstanding comments, thank you again for your confirmation in the meantime!

@ia3andy
Copy link
Contributor

ia3andy commented Oct 15, 2021

@ia3andy thank you for feedback, re:

extension codestarts should not contain business/example logic, but initial/hello code to start developing from. Is DMN fitting this? from a quick look at the quickstart, it seems it does, a few extra resources files right?

any Kogito extension deals with expressing business logic with DMN, DRL, etc resource assets, so the moment I drop a DMN resource it will contain some form of logic anyway. I would like for the Codestart to have this "logic" veeery trivial as described here

That's a DMN-hello world kind of example, from my perspective.

The reason I'm asking, is that I got on my laps a PM request for a Codestart (in addition to the exiting Quickstart which is more evolved) with a simple DMN example, and I believe that fits. As I noticed this github issue is resolved, I wanted to start working on that request I received.

I will proceed in this way unless there are outstanding comments, thank you again for your confirmation in the meantime!

That sounds good @tarilabs.

Let me know how it goes, it's all pretty fresh :) don't hesitate if you have a problem or something seems wrong..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants