Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute paths in pom.xml #10953

Closed
zakkak opened this issue Jul 24, 2020 · 4 comments · Fixed by #10994
Closed

Absolute paths in pom.xml #10953

zakkak opened this issue Jul 24, 2020 · 4 comments · Fixed by #10994
Assignees
@aloubyansky
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
1.7.0.CR1

Comments

@zakkak
Copy link
Contributor

zakkak commented Jul 24, 2020

Description
In https://github.com/quarkusio/quarkus/blob/master/integration-tests/maven/src/test/resources/projects/project-with-extension/runner/pom.xml there are 3 instances of absolute paths.

quarkus/integration-tests/maven/src/test/resources/projects/project-with-extension/runner/pom.xml

Line 52 in 42dbdd0

<maven.home>/home/olubyans/maven</maven.home>

quarkus/integration-tests/maven/src/test/resources/projects/project-with-extension/runner/pom.xml

Line 115 in 42dbdd0

<native.image.path>/home/olubyans/git/quarkus/integration-tests/maven/target/quarkus-integration-test-maven-999-SNAPSHOT-runner</native.image.path>

quarkus/integration-tests/maven/src/test/resources/projects/project-with-extension/runner/pom.xml

Line 117 in 42dbdd0

<maven.home>/home/olubyans/maven</maven.home>

Implementation ideas
maven.home should probably be <maven.home>${maven.home}</maven.home> and native.image.path should probably be <native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path>
@zakkak zakkak added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 24, 2020
@geoand
Copy link
Contributor

geoand commented Jul 24, 2020

@aloubyansky seems like an oversight :)

@aloubyansky
Copy link
Member

omg

@aloubyansky aloubyansky self-assigned this Jul 24, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 27, 2020
@gsmet
Copy link
Member

gsmet commented Jul 27, 2020

@aloubyansky can you make sure we fix this before Thursday? Thanks!

@aloubyansky aloubyansky mentioned this issue Jul 27, 2020
Merged
@aloubyansky
Copy link
Member

PR opened @gsmet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloubyansky aloubyansky

Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging a pull request may close this issue.

Fixed Maven test pom property values aloubyansky/quarkus
4 participants
@aloubyansky @gsmet @zakkak @geoand