Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Protocol Buffer library #10947

Closed
mthmulders opened this issue Jul 23, 2020 · 4 comments · Fixed by #10951
Closed

Update Protocol Buffer library #10947

mthmulders opened this issue Jul 23, 2020 · 4 comments · Fixed by #10951
Assignees
@michalszynkiewicz
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone
1.7.0.CR1

Comments

@mthmulders
Copy link
Contributor

Description
The Quarkus Universe BOM declares version 3.6.1 of the com.google.protobuf:protobuf-java artifact. This version uses illegal reflective access, which causes warnings in Java 9 and up. According to protocolbuffers/protobuf#3781, fixed in January 2019.

Implementation ideas
Update the version declaration of com.google.protobuf:protobuf-java to the most recent version, 3.12.3 at this moment. I'm willing to provide a pull request for this, if necessary. Just need a pointer where the version is defined :-)
@mthmulders mthmulders added the kind/enhancement New feature or request label Jul 23, 2020
@mthmulders
Copy link
Contributor Author

Maybe a duplicate of #10214 since that already upgrades Protocol Buffers to 3.11.x...

@jaikiran jaikiran added the area/grpc gRPC label Jul 24, 2020
@jaikiran
Copy link
Member

Update the version declaration of com.google.protobuf:protobuf-java to the most recent version, 3.12.3 at this moment

Perhaps @michalszynkiewicz would know if we should move to 3.12.x of this library?

@michalszynkiewicz michalszynkiewicz self-assigned this Jul 24, 2020
@michalszynkiewicz
Copy link
Member

updating all grpc-related things is on my todo list, I am testing an update to 3.12.2/3.12.3, will do a PR if it works

@michalszynkiewicz michalszynkiewicz mentioned this issue Jul 24, 2020
Merged
@mthmulders
Copy link
Contributor Author

Amazing, thanks a lot!

@gsmet gsmet added this to the 1.7.0 - master milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalszynkiewicz michalszynkiewicz

Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging a pull request may close this issue.

update protobuf and grpc dependencies michalszynkiewicz/quarkus
4 participants
@jaikiran @mthmulders @gsmet @michalszynkiewicz