-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Various YAML configuration issues in 1.6.1.Final #10916
Comments
@radcortez are you planning on looking into this or should I? |
@geoand already did. These issues are localised only in the YAML Config Source, so it is easy to workaround by downgrading to the last dependency like stated by @famod without affecting the configuration core. All the reported issues are already fixed in SmallRye Config and just require a release and minor bump in the Quarkus dependency. @famod Thank you for all the help and report! |
Excellent, thanks @radcortez |
Thanks for reporting and finding the underlying issue, we were also encountering the same behaviour after upgrading to 1.6.1 The suggested workaround works here too, thanks! |
@radcortez not on my side, but we updated just yesterday. I am not "at work" today so I don't know whether anything new popped up. |
Ok :) |
Yeah, unless something critical with no workaround comes up, I won't do an 1.6.2. |
@radcortez I just realized that 1.7.0.CR1 is already slated for the day after tomorrow. I guess it is not a showstopper if it misses CR1 (and lands in Final instead), but it would be great if you could manage to get the update of SmallRye Config into CR1. |
Note that I will be a bit nervous to upgrade SmallRye Config post CR1 so let's try to get this in before CR1 please. |
Yes, all the fixes are in. I just need to push the release and do the update. @famod you were able to confirm that the fixes, did indeed solve the problems, right? |
Unfortunately I have not yet checked your fixes. Do you have a SNAPSHOT-release somewhere? |
Yes, I can push one to Central. |
Ok 1.8.5-SNAPSHOT should be available here: https://oss.sonatype.org/content/repositories/snapshots/ |
@radcortez I can confirm, that this snapshot fixes the regressions. Excellent work. |
@tkalmar Thank you very much for checking. Ok pushing a stable release! |
Can confirm that the snapshot release fixes the regressions indeed, thanks @radcortez! |
@wjglerum Thanks for checking :) |
Thanks all! This is how the community should work. |
Indeed :) |
Please allow me to skip the issue-template for this since it has already been taken care of in
smallrye-config
1.8.5 which Quarkus should update to ASAP when that version is released.See:
C&P of two manifestion of those problems:
Those
.[x]
-warnings are actually false negatives but the loglevel related warnings are correct.Temporary Workaround:
Add this to your Maven
dependencyManagement
, beforequarkus-bom
orquarkus-universe-bom
:/cc @radcortez @geoand @gsmet
The text was updated successfully, but these errors were encountered: