Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Various YAML configuration issues in 1.6.1.Final #10916

Closed
famod opened this issue Jul 22, 2020 · 21 comments · Fixed by #11041
Closed

Regression: Various YAML configuration issues in 1.6.1.Final #10916

famod opened this issue Jul 22, 2020 · 21 comments · Fixed by #11041
Assignees
Labels
area/config kind/bug Something isn't working
Milestone

Comments

@famod
Copy link
Member

famod commented Jul 22, 2020

Please allow me to skip the issue-template for this since it has already been taken care of in smallrye-config 1.8.5 which Quarkus should update to ASAP when that version is released.
See:

C&P of two manifestion of those problems:

11:36:10,778 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.cipher-suites.[2]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,778 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.cipher-suites.[1]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,778 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.cipher-suites.[4]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,778 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.cipher-suites.[3]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,779 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.cipher-suites.[5]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,779 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.protocols.[1]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,779 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.protocols.[0]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,779 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.log.category.liquibase.changelog.ChangeSet.level" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,779 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.log.category.com.somecompany.someproject.middleware.level" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo
11:36:10,779 WARN  [io.qua.config] (Quarkus Main Thread) Unrecognized configuration key "quarkus.http.ssl.cipher-suites.[0]" was provided; it will be ignored; verify that the dependency extension for this configuration is set or you did not make a typo

Those .[x]-warnings are actually false negatives but the loglevel related warnings are correct.

Temporary Workaround:
Add this to your Maven dependencyManagement, before quarkus-bom or quarkus-universe-bom:

<dependency>
    <groupId>io.smallrye.config</groupId>
    <artifactId>smallrye-config-source-yaml</artifactId>
    <version>1.8.1</version>
</dependency>

/cc @radcortez @geoand @gsmet

@famod famod added kind/bug Something isn't working area/config labels Jul 22, 2020
@famod famod changed the title Various YAML configuration issues in 1.6.1.Final Regression: Various YAML configuration issues in 1.6.1.Final Jul 22, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 22, 2020
@geoand
Copy link
Contributor

geoand commented Jul 22, 2020

@radcortez are you planning on looking into this or should I?

@radcortez
Copy link
Member

@geoand already did.

These issues are localised only in the YAML Config Source, so it is easy to workaround by downgrading to the last dependency like stated by @famod without affecting the configuration core.

All the reported issues are already fixed in SmallRye Config and just require a release and minor bump in the Quarkus dependency.

@famod Thank you for all the help and report!

@radcortez radcortez self-assigned this Jul 22, 2020
@geoand
Copy link
Contributor

geoand commented Jul 23, 2020

Excellent, thanks @radcortez

@famod
Copy link
Member Author

famod commented Jul 23, 2020

@famod Thank you for all the help and report!

You're welcome! We also have to thank @tkalmar for his support.
And thank you for reacting so quickly!

@wjglerum
Copy link
Contributor

wjglerum commented Jul 24, 2020

Thanks for reporting and finding the underlying issue, we were also encountering the same behaviour after upgrading to 1.6.1

The suggested workaround works here too, thanks!

@radcortez
Copy link
Member

@famod @tkalmar @wjglerum did any of you find anything else? If not, I can push a release of SmallRye Config.

@famod
Copy link
Member Author

famod commented Jul 24, 2020

@radcortez not on my side, but we updated just yesterday. I am not "at work" today so I don't know whether anything new popped up.
Since there is a workaround and @gsmet assigned it to 1.7.0 (and not flagged it with backport?), I personally could wait until next week or so.

@radcortez
Copy link
Member

Ok :)

@gsmet
Copy link
Member

gsmet commented Jul 24, 2020

Yeah, unless something critical with no workaround comes up, I won't do an 1.6.2.

@famod
Copy link
Member Author

famod commented Jul 27, 2020

@radcortez I just realized that 1.7.0.CR1 is already slated for the day after tomorrow.

I guess it is not a showstopper if it misses CR1 (and lands in Final instead), but it would be great if you could manage to get the update of SmallRye Config into CR1.

@gsmet
Copy link
Member

gsmet commented Jul 28, 2020

Note that I will be a bit nervous to upgrade SmallRye Config post CR1 so let's try to get this in before CR1 please.

@radcortez
Copy link
Member

Yes, all the fixes are in. I just need to push the release and do the update. @famod you were able to confirm that the fixes, did indeed solve the problems, right?

@famod
Copy link
Member Author

famod commented Jul 28, 2020

I just need to push the release and do the update. @famod you were able to confirm that the fixes, did indeed solve the problems, right?

Unfortunately I have not yet checked your fixes. Do you have a SNAPSHOT-release somewhere?
I would need to focus on the first two fixes since my team is not affected by the third one.

@radcortez
Copy link
Member

Yes, I can push one to Central.

@radcortez
Copy link
Member

Ok 1.8.5-SNAPSHOT should be available here: https://oss.sonatype.org/content/repositories/snapshots/

@tkalmar
Copy link

tkalmar commented Jul 28, 2020

@radcortez I can confirm, that this snapshot fixes the regressions. Excellent work.

@radcortez
Copy link
Member

@tkalmar Thank you very much for checking. Ok pushing a stable release!

@wjglerum
Copy link
Contributor

Can confirm that the snapshot release fixes the regressions indeed, thanks @radcortez!

@radcortez
Copy link
Member

@wjglerum Thanks for checking :)

@famod
Copy link
Member Author

famod commented Jul 28, 2020

Thanks all! This is how the community should work.

@radcortez
Copy link
Member

Thanks all! This is how the community should work.

Indeed :)

@gastaldi gastaldi linked a pull request Jul 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants