Specifying ignoredEntries for quarkus-maven-plugin has no effect

[sebthom]

Describe the bug
Specifying <ignoredEntries><ignoredEntry> settings in quarkus-maven-plugin maven configuration has no effect.
The resulting uberJar still contains all files that are marked for exclusion.

Expected behavior
Specified exclusions are processed and the listed files are excluded from the uberJar.

Actual behavior
Files matching specified exclusions are excluded from resulting jar.

To Reproduce
Steps to reproduce the behavior:

1. mvn clean package

Configuration
Plugin configuration in the pom.xml:

         <plugin>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-maven-plugin</artifactId>
            <version>${quarkus.version}</version>
            <executions>
               <execution>
                  <goals>
                     <goal>build</goal>
                  </goals>
                  <configuration>
                     <uberJar>true</uberJar>
                     <ignoredEntries>
                        <ignoredEntry>META-INF/swagger-ui-files/swagger-ui-bundle.js.map</ignoredEntry>
                        <ignoredEntry>META-INF/swagger-ui-files/swagger-ui-standalone-preset.js.map</ignoredEntry>
                     </ignoredEntries>
                  </configuration>
               </execution>
            </executions>
         </plugin>

Environment (please complete the following information):

• Output of uname -a or ver: Windows 10x64
• Output of java -version:

  openjdk version "11.0.7" 2020-04-14
  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.7+10)
  OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.7+10, mixed mode)
  

• GraalVM version (if different from Java): n/a
• Quarkus version or git rev: 1.5.2.Final and 1.6.0.CR1
• Build tool (ie. output of mvnw --version or gradlew --version): Apache Maven 3.6.3

Additional information:
Looking at the source code of the Quarkus Maven Build Goal, it seems like someone forgot to actually implement processing of ignoredEntries: https://github.com/quarkusio/quarkus/blob/1.6.0.CR1/devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java#L126
A private field ignoredEntries is defined but it is not used in the code.

[quarkusbot]

/cc @quarkusio/devtools

[aloubyansky]

Here is a consequence of adding a feature w/o any test. bf26eb8#diff-fc5bfcac2e033b00de4f2bfe6b02a1ac

[sebthom]

This looks like the commit that broke the feature: 0d3335d#diff-fc5bfcac2e033b00de4f2bfe6b02a1ac

[gastaldi]

Apparently they are no longer specified in the plugin, but in the application.properties:

quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/PackageConfig.java

Lines 58 to 62 in 41b3c45

	/**
	* Files that should not be copied to the output artifact
	*/
	@ConfigItem
	public Optional<List<String>> userConfiguredIgnoredEntries;

I tried adding these to the application.properties but it still didn't work:

quarkus.package.user-configured-ignored-entries=META-INF/swagger-ui-files/swagger-ui-bundle.js.map,META-INF/swagger-ui-files/swagger-ui-standalone-preset.js.map

I'm investigating it

[sebthom]

Probably quarkus.package.user-configured-ignored-entries is processed before the uberJar is created. I am looking for a way to get rid of unnecessary files from the uberJar that come from maven dependencies.

[gastaldi]

@sebthom I might have fixed this in: #10415

Can you give it a try?

[sebthom]

@gastaldi I just tried it. It seems to work now. Thanks for the quick fix! Unfortunately it does not work with wildcards, e.g. META-INF/swagger-ui-files/*.js.map or even better META-INF/**/*.js.map, but I guess that is a different story.

[gastaldi]

Thanks @sebthom. I created #10441 requesting wildcard support.