Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Default to Deployment rather than DeploymentConfiguration also for OpenShift #10163

Open
fgiloux opened this issue Jun 22, 2020 · 3 comments
Assignees
Labels

Comments

@fgiloux
Copy link

fgiloux commented Jun 22, 2020

Description
Not only for Kubernetes but also for OpenShift Deployment should be preferred to DeploymentConfiguration, cf OpenShift documentation:
https://docs.openshift.com/container-platform/4.4/applications/deployments/what-deployments-are.html#deployments-comparing-deploymentconfigs_what-deployments-are

Note that ImageChangeTrigger is also available with Deployment, this can be configured by setting an annotation, example:
$ oc set triggers deploy/example --from-image=example:latest -c web
will create a trigger so that the image reference in the Deployment "example" for the container "web" will be updated any time a new image is pushed to example:latest. The change in Deployment configuration will then automatically trigger a new deployment.
More information at: https://docs.openshift.com/container-platform/3.11/dev_guide/managing_images.html#image-stream-kubernetes-resources

Today the file target/kubernetes/openshift.yml contains a DeploymentConfiguration this RFE proposes to use a Deployment with an image change trigger annotation instead.

@fgiloux fgiloux added the kind/enhancement New feature or request label Jun 22, 2020
@geoand
Copy link
Contributor

geoand commented Jun 22, 2020

Similar to: #10055

@iocanel I think we need to rethink the Openshift target, or at least make it more configurable

@geoand
Copy link
Contributor

geoand commented Jul 27, 2021

@iocanel you had something like this in pipeline, right?

@iocanel
Copy link
Contributor

iocanel commented Oct 11, 2021

This is next on my list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants