Improvements to Jackson reflection for the KC model #42110
jorsol
started this conversation in
Design Discussions
Replies: 2 comments 4 replies
-
Beta Was this translation helpful? Give feedback.
1 reply
-
Beta Was this translation helpful? Give feedback.
-
|
On an empty project (no source code) downloaded from code.quarkus.io with just the Used classes report |
Beta Was this translation helpful? Give feedback.
3 replies
-
|
Excluding most of the model except for With excluded modelWith the following exclusions except: kubernetes-model-admissionregistration, kubernetes-model-batch, kubernetes-model-certificates, kubernetes-model-coordination, kubernetes-model-node, kubernetes-model-apps, kubernetes-model-extensions allows it to build correctly, yet the conclusion is that is registering more than needed. <exclusions>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-gatewayapi</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-resource</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-rbac</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-autoscaling</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-apiextensions</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-discovery</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-events</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-flowcontrol</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-networking</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-metrics</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-policy</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-scheduling</artifactId>
</exclusion>
<exclusion>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-model-storageclass</artifactId>
</exclusion>
</exclusions>Apparently the KubernetesClientImpl is cascading the model due the use of the DSL. So, this might be an area of improvement, and if Quarkus can effectively detect what parts of the model are being used, that would allow the removal of registration of classes that are not needed. |
Beta Was this translation helpful? Give feedback.
-
|
The challenge here is that most access to kubernetes model is done programmatically; not declaratively so no (obvious) way to identify what is being used/not used. That + historically the generated model in k8s ends up highly coupled if we aren't careful causes issues. @iocanel and @andreaTP been talking about options in past. Not having to include everything all the time isn't one we entertained yet - but maybe we should? |
Beta Was this translation helpful? Give feedback.
-
|
In the client side the model is nicely split in independent modules. I don't see why we can't do the same for think client modules. Then users that feel the need to reduce the size can hand pick the think client they want. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is to follow up the discussion from #42028 to reduce or eliminate the use of reflection, the Kubernetes-Client has a pretty large set of model classes that increase the size and build time of the native-image generation, and this discussion aims to evaluate potential improvements on this and not miss it on a PR.
While the major issue is noticed with KC, this affects any part where Jackson serialization is used, Mario Fusco is working on a PoC to generate ObjectMappers at build time via gizmo.
Also, it might be worth investigating whether we could have a Jandex-based collector in Jackson.
The KC team is also exploring ideas on how to improve this from the client.
The discussion can continue here.
Beta Was this translation helpful? Give feedback.
All reactions