From fd71e2dc832cd7002e1e490b692054b2db1326bd Mon Sep 17 00:00:00 2001 From: jeanphibaconnais Date: Mon, 9 May 2022 12:52:01 +0000 Subject: [PATCH] GitPod - review - add changes on Dockerfile and quarkus command --- .gitpod.yml | 3 ++- .gitpod/Dockerfile | 22 +++++----------------- CONTRIBUTING.md | 2 +- 3 files changed, 8 insertions(+), 19 deletions(-) diff --git a/.gitpod.yml b/.gitpod.yml index 833cc712e498c..3d06e70f531f3 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -5,7 +5,7 @@ image: file: .gitpod/Dockerfile tasks: - - init: ./mvnw install -DskipTests=false + - init: ./mvnw -Dquickly - name: Quarkus command openMode: split-right @@ -14,3 +14,4 @@ vscode: - "redhat.java" - "vscjava.vscode-java-dependency" - "vscjava.vscode-java-debug" + - "vscjava.vscode-java-pack" diff --git a/.gitpod/Dockerfile b/.gitpod/Dockerfile index 29ae69591aebb..f15c4361b51e9 100644 --- a/.gitpod/Dockerfile +++ b/.gitpod/Dockerfile @@ -1,20 +1,8 @@ -FROM gitpod/workspace-full -USER gitpod +FROM gitpod/workspace-java-11 -ARG JAVA_VERSION="11.0.9.j9-adpt" - -# install sdkman -RUN curl -s "https://get.sdkman.io" | bash - -RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && \ - yes | sdk install jbang && \ +RUN bash -c ". /home/gitpod/.sdkman/bin/sdkman-init.sh && \ + sdk install java 11.0.9.j9-adpt && \ + sdk use java 11.0.9.j9-adpt && \ + yes | sdk install quarkus && \ rm -rf $HOME/.sdkman/archives/* && \ rm -rf $HOME/.sdkman/tmp/* " - -# install jbang -RUN bash -c '$HOME/.sdkman/candidates/jbang/current/bin/jbang --version' - -RUN bash -c '$HOME/.sdkman/candidates/jbang/current/bin/jbang trust add https://repo1.maven.org/maven2/io/quarkus/quarkus-cli/' - -# install quarkus cli -RUN bash -c '$HOME/.sdkman/candidates/jbang/current/bin/jbang app install --fresh --force quarkus@quarkusio' \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d74ba7c9824b7..7ddda08f503ab 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -291,7 +291,7 @@ Do the same with _Names count to use static import with '\*'_. ### GitPod -You can also use [GitPod](https://gitpod.io) to contribute without install anything on your computer. Click [here](#https://gitpod.io/https://github.com/quarkusio/quarkus/-/tree/main/) to start a workspace. +You can also use [GitPod](https://gitpod.io) to contribute without install anything on your computer. Click [here](https://gitpod.io/#https://github.com/quarkusio/quarkus/-/tree/main/) to start a workspace. ## Build