From e292b212cce197d218e5aa5edb91351efc5c2ad3 Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Wed, 12 Oct 2022 15:12:04 +0200 Subject: [PATCH] Improve error feedback for Keycloak dev service startup Fixes #25809 --- .../io/quarkus/dev/console/BasicConsole.java | 1 - .../KeycloakDevServicesProcessor.java | 76 +++++++++++++------ 2 files changed, 51 insertions(+), 26 deletions(-) diff --git a/core/devmode-spi/src/main/java/io/quarkus/dev/console/BasicConsole.java b/core/devmode-spi/src/main/java/io/quarkus/dev/console/BasicConsole.java index f125065d0bccd3..85acf9df025432 100644 --- a/core/devmode-spi/src/main/java/io/quarkus/dev/console/BasicConsole.java +++ b/core/devmode-spi/src/main/java/io/quarkus/dev/console/BasicConsole.java @@ -127,7 +127,6 @@ public void setMessage(String message) { } finally { DISABLE_FILTER.set(false); } - } @Override diff --git a/extensions/oidc/deployment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java b/extensions/oidc/deployment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java index 34a1a4cb0918e9..31f90109de2556 100644 --- a/extensions/oidc/deployment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java +++ b/extensions/oidc/deployment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java @@ -181,17 +181,24 @@ public DevServicesResultBuildItem startKeycloakContainer( } capturedDevServicesConfiguration = currentDevServicesConfiguration; StartupLogCompressor compressor = new StartupLogCompressor( - (launchMode.isTest() ? "(test) " : "") + "KeyCloak Dev Services Starting:", + (launchMode.isTest() ? "(test) " : "") + "Keycloak Dev Services Starting:", consoleInstalledBuildItem, loggingSetupBuildItem); if (vertxInstance == null) { vertxInstance = Vertx.vertx(); } try { + List errors = new ArrayList<>(); + RunningDevService newDevService = startContainer(dockerStatusBuildItem, keycloakBuildItemBuildProducer, !devServicesSharedNetworkBuildItem.isEmpty(), - devServicesConfig.timeout); + devServicesConfig.timeout, + errors); if (newDevService == null) { - compressor.close(); + if (errors.isEmpty()) { + compressor.close(); + } else { + compressor.closeAndDumpCaptured(); + } return null; } @@ -227,10 +234,10 @@ public void run() { } capturedRealmFileLastModifiedDate = getRealmFileLastModifiedDate(capturedDevServicesConfiguration.realmPath); - if (devService == null) { - compressor.closeAndDumpCaptured(); - } else { + if (devService != null && errors.isEmpty()) { compressor.close(); + } else { + compressor.closeAndDumpCaptured(); } } catch (Throwable t) { compressor.closeAndDumpCaptured(); @@ -241,14 +248,14 @@ public void run() { return devService.toBuildItem(); } - private String startURL(String host, Integer port, boolean isKeyCloakX) { - return "http://" + host + ":" + port + (isKeyCloakX ? "" : "/auth"); + private String startURL(String host, Integer port, boolean isKeycloakX) { + return "http://" + host + ":" + port + (isKeycloakX ? "" : "/auth"); } private Map prepareConfiguration( BuildProducer keycloakBuildItemBuildProducer, String internalURL, String hostURL, RealmRepresentation realmRep, - boolean keycloakX) { + boolean keycloakX, List errors) { final String realmName = realmRep != null ? realmRep.getRealm() : getDefaultRealmName(); final String authServerInternalUrl = realmsURL(internalURL, realmName); @@ -266,9 +273,10 @@ private Map prepareConfiguration( try { String adminToken = getAdminToken(client, clientAuthServerBaseUrl); if (createDefaultRealm) { - createDefaultRealm(client, adminToken, clientAuthServerBaseUrl, users, oidcClientId, oidcClientSecret); + createDefaultRealm(client, adminToken, clientAuthServerBaseUrl, users, oidcClientId, oidcClientSecret, + errors); } else if (realmRep != null && keycloakX) { - createRealm(client, adminToken, clientAuthServerBaseUrl, realmRep); + createRealm(client, adminToken, clientAuthServerBaseUrl, realmRep, errors); } } finally { client.close(); @@ -300,7 +308,8 @@ private String getDefaultRealmName() { private RunningDevService startContainer(DockerStatusBuildItem dockerStatusBuildItem, BuildProducer keycloakBuildItemBuildProducer, - boolean useSharedNetwork, Optional timeout) { + boolean useSharedNetwork, Optional timeout, + List errors) { if (!capturedDevServicesConfiguration.enabled) { // explicitly disabled LOG.debug("Not starting Dev Services for Keycloak as it has been disabled in the config"); @@ -342,7 +351,8 @@ private RunningDevService startContainer(DockerStatusBuildItem dockerStatusBuild capturedDevServicesConfiguration.shared, capturedDevServicesConfiguration.javaOpts, capturedDevServicesConfiguration.startCommand, - capturedDevServicesConfiguration.showLogs); + capturedDevServicesConfiguration.showLogs, + errors); timeout.ifPresent(oidcContainer::withStartupTimeout); oidcContainer.start(); @@ -356,7 +366,8 @@ private RunningDevService startContainer(DockerStatusBuildItem dockerStatusBuild Map configs = prepareConfiguration(keycloakBuildItemBuildProducer, internalUrl, hostUrl, oidcContainer.realmRep, - oidcContainer.keycloakX); + oidcContainer.keycloakX, + errors); return new RunningDevService(KEYCLOAK_CONTAINER_NAME, oidcContainer.getContainerId(), oidcContainer::close, configs); }; @@ -366,7 +377,7 @@ private RunningDevService startContainer(DockerStatusBuildItem dockerStatusBuild // TODO: this probably needs to be addressed Map configs = prepareConfiguration(keycloakBuildItemBuildProducer, getSharedContainerUrl(containerAddress), - getSharedContainerUrl(containerAddress), null, false); + getSharedContainerUrl(containerAddress), null, false, errors); return new RunningDevService(KEYCLOAK_CONTAINER_NAME, containerAddress.getId(), null, configs); }) .orElseGet(defaultKeycloakContainerSupplier); @@ -395,10 +406,12 @@ private static class QuarkusOidcContainer extends GenericContainer startCommand; private final boolean showLogs; + private final List errors; public QuarkusOidcContainer(DockerImageName dockerImageName, OptionalInt fixedExposedPort, boolean useSharedNetwork, Optional realmPath, String containerLabelValue, - boolean sharedContainer, Optional javaOpts, Optional startCommand, boolean showLogs) { + boolean sharedContainer, Optional javaOpts, Optional startCommand, boolean showLogs, + List errors) { super(dockerImageName); this.useSharedNetwork = useSharedNetwork; @@ -418,6 +431,7 @@ public QuarkusOidcContainer(DockerImageName dockerImageName, OptionalInt fixedEx this.fixedExposedPort = fixedExposedPort; this.startCommand = startCommand; this.showLogs = showLogs; + this.errors = errors; super.setWaitStrategy(Wait.forLogMessage(".*Keycloak.*started.*", 1)); } @@ -468,7 +482,7 @@ protected void configure() { if (realmPath.isPresent()) { URL realmPathUrl = null; if ((realmPathUrl = Thread.currentThread().getContextClassLoader().getResource(realmPath.get())) != null) { - realmRep = readRealmFile(realmPathUrl, realmPath.get()); + realmRep = readRealmFile(realmPathUrl, realmPath.get(), errors); if (!keycloakX) { withClasspathResourceMapping(realmPath.get(), KEYCLOAK_DOCKER_REALM_PATH, BindMode.READ_ONLY); } @@ -478,9 +492,11 @@ protected void configure() { if (!keycloakX) { withFileSystemBind(realmPath.get(), KEYCLOAK_DOCKER_REALM_PATH, BindMode.READ_ONLY); } - realmRep = readRealmFile(filePath.toUri(), realmPath.get()); + realmRep = readRealmFile(filePath.toUri(), realmPath.get(), errors); } else { - LOG.debugf("Realm %s resource is not available", realmPath.get()); + errors.add(String.format("Realm %s resource is not available", realmPath.get())); + + LOG.errorf("Realm %s resource is not available", realmPath.get()); } } @@ -507,21 +523,23 @@ private Integer findRandomPort() { } } - private RealmRepresentation readRealmFile(URI uri, String realmPath) { + private RealmRepresentation readRealmFile(URI uri, String realmPath, List errors) { try { - return readRealmFile(uri.toURL(), realmPath); + return readRealmFile(uri.toURL(), realmPath, errors); } catch (MalformedURLException ex) { // Will not happen as this method is called only when it is confirmed the file exists throw new RuntimeException(ex); } } - private RealmRepresentation readRealmFile(URL url, String realmPath) { + private RealmRepresentation readRealmFile(URL url, String realmPath, List errors) { try { try (InputStream is = url.openStream()) { return JsonSerialization.readValue(is, RealmRepresentation.class); } } catch (IOException ex) { + errors.add(String.format("Realm %s resource can not be opened: %s", realmPath, ex.getMessage())); + LOG.errorf("Realm %s resource can not be opened: %s", realmPath, ex.getMessage()); } return null; @@ -578,7 +596,8 @@ private FileTime getRealmFileLastModifiedDate(Optional realm) { private void createDefaultRealm(WebClient client, String token, String keycloakUrl, Map users, String oidcClientId, - String oidcClientSecret) { + String oidcClientSecret, + List errors) { RealmRepresentation realm = createDefaultRealmRep(); realm.getClients().add(createClient(oidcClientId, oidcClientSecret)); @@ -586,7 +605,7 @@ private void createDefaultRealm(WebClient client, String token, String keycloakU realm.getUsers().add(createUser(entry.getKey(), entry.getValue(), getUserRoles(entry.getKey()))); } - createRealm(client, token, keycloakUrl, realm); + createRealm(client, token, keycloakUrl, realm, errors); } private String getAdminToken(WebClient client, String keycloakUrl) { @@ -602,7 +621,8 @@ private String getAdminToken(WebClient client, String keycloakUrl) { return null; } - private void createRealm(WebClient client, String token, String keycloakUrl, RealmRepresentation realm) { + private void createRealm(WebClient client, String token, String keycloakUrl, RealmRepresentation realm, + List errors) { try { LOG.tracef("Creating the realm %s", realm.getRealm()); HttpResponse createRealmResponse = client.postAbs(keycloakUrl + "/admin/realms") @@ -612,6 +632,10 @@ private void createRealm(WebClient client, String token, String keycloakUrl, Rea .await().atMost(oidcConfig.devui.webClientTimeout); if (createRealmResponse.statusCode() > 299) { + errors.add(String.format("Realm %s can not be created %d - %s ", realm.getRealm(), + createRealmResponse.statusCode(), + createRealmResponse.statusMessage())); + LOG.errorf("Realm %s can not be created %d - %s ", realm.getRealm(), createRealmResponse.statusCode(), createRealmResponse.statusMessage()); } @@ -635,6 +659,8 @@ private void createRealm(WebClient client, String token, String keycloakUrl, Rea }); realmStatusCodeUni.await().atMost(Duration.ofSeconds(10)); } catch (Throwable t) { + errors.add(String.format("Realm %s can not be created: %s", realm.getRealm(), t.getMessage())); + LOG.errorf("Realm %s can not be created: %s", realm.getRealm(), t.getMessage()); } }