From af8ecf25abcdaa65dd301c1f6dfed925e9700e5f Mon Sep 17 00:00:00 2001 From: Stuart Douglas Date: Mon, 22 Feb 2021 09:50:27 +1100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Guillaume Smet --- docs/src/main/asciidoc/datasource.adoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/src/main/asciidoc/datasource.adoc b/docs/src/main/asciidoc/datasource.adoc index 4eeacb012652ee..f4c4369477a848 100644 --- a/docs/src/main/asciidoc/datasource.adoc +++ b/docs/src/main/asciidoc/datasource.adoc @@ -72,7 +72,7 @@ quarkus.datasource.jdbc.url=jdbc:postgresql://localhost:5432/hibernate_orm_test quarkus.datasource.jdbc.max-size=16 ---- <1> If you only have a single JDBC extension, or you are running tests and only have a single test scoped JDBC extension installed then this is -optional. If there is only once possible extension we assume this is the correct one, and if a driver has been added with test scope then +optional. If there is only one possible extension we assume this is the correct one, and if a driver has been added with test scope then we assume that this should be used in testing. === Reactive datasource @@ -83,7 +83,7 @@ Then configure your reactive datasource: [source, properties] ---- -quarkus.datasource.db-kind=postgresql<1> +quarkus.datasource.db-kind=postgresql <1> quarkus.datasource.username= quarkus.datasource.password= @@ -403,7 +403,7 @@ quarkus.datasource.inventory.jdbc.max-size=12 Notice there is an extra bit in the key. The syntax is as follows: `quarkus.datasource.[optional name.][datasource property]`. -NOTE: Even when only one database extension is installed named databases need to specify at least one build time +NOTE: Even when only one database extension is installed, named databases need to specify at least one build time property so that Quarkus knows they exist. Generally this will be the `db-kind` property, although you can also specify DevServices properties to create named datasources (covered later in this guide). @@ -463,7 +463,7 @@ You can override this by setting the `transactions` configuration property - see == DevDb (Configuration Free Databases) As mentioned above Quarkus supports a feature called DevServices that allows you to create datasources without any config. If -you have a database extension that supports it and no config is provided Quarkus will automatically start a database (either +you have a database extension that supports it and no config is provided, Quarkus will automatically start a database (either using Testcontainers, or by starting a Java DB in process), and automatically configure a connection to this database. Production databases need to be configured as normal, so if you want to include a production database config in your