From ae363a05e57f266743c4143a2700d259e882756d Mon Sep 17 00:00:00 2001 From: Georgios Andrianakis Date: Fri, 12 Mar 2021 12:14:53 +0200 Subject: [PATCH] Change default value of quarkus.kubernetes-service-binding.enabled to true The basic idea is that when the extension is present, an attempt to find the service bindings makes most sense as the default behavior. --- docs/src/main/asciidoc/deploying-to-kubernetes.adoc | 4 +--- .../binding/runtime/KubernetesServiceBindingConfig.java | 2 +- integration-tests/kubernetes-service-binding-jdbc/pom.xml | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/docs/src/main/asciidoc/deploying-to-kubernetes.adoc b/docs/src/main/asciidoc/deploying-to-kubernetes.adoc index 83ab4d287c9bf..b57e90a595ca3 100644 --- a/docs/src/main/asciidoc/deploying-to-kubernetes.adoc +++ b/docs/src/main/asciidoc/deploying-to-kubernetes.adoc @@ -1201,8 +1201,7 @@ Currently, the following Quarkus extensions support this feature: This list of extensions will grow as more services with supported bindings become available on Kubernetes. -To enable Service Binding support, in addition to one of the currently supported extensions, the `quarkus-kubernetes-service-binding` extension needs to be added to the application dependencies as well as -having the `quarkus.kubernetes-service-binding.enabled` configuration property set to `true`. +To enable Service Binding support, in addition to one of the currently supported extensions, the `quarkus-kubernetes-service-binding` extension needs to be added to the application dependencies. === Example using PostgreSQL @@ -1230,7 +1229,6 @@ The configuration of the application could be as simple as: [source,properties] ---- -quarkus.kubernetes-service-binding.enabled=true quarkus.hibernate-orm.database.generation=validate ---- diff --git a/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/KubernetesServiceBindingConfig.java b/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/KubernetesServiceBindingConfig.java index a77e90540ebc7..a024098c77230 100644 --- a/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/KubernetesServiceBindingConfig.java +++ b/extensions/kubernetes-service-binding/runtime/src/main/java/io/quarkus/kubernetes/service/binding/runtime/KubernetesServiceBindingConfig.java @@ -12,7 +12,7 @@ public class KubernetesServiceBindingConfig { /** * If enabled, Service Bindings will be looked in the file system */ - @ConfigItem + @ConfigItem(defaultValue = "true") public boolean enabled; /** diff --git a/integration-tests/kubernetes-service-binding-jdbc/pom.xml b/integration-tests/kubernetes-service-binding-jdbc/pom.xml index 164ead097e24e..67becae685e91 100644 --- a/integration-tests/kubernetes-service-binding-jdbc/pom.xml +++ b/integration-tests/kubernetes-service-binding-jdbc/pom.xml @@ -166,7 +166,6 @@ ${project.basedir}/src/test/resources/k8s-sb - true