From 9e8032ce171d587abbb66711b870fbbbc4a98b94 Mon Sep 17 00:00:00 2001 From: Holly Cummins Date: Fri, 5 Jul 2024 16:56:43 +0100 Subject: [PATCH] Tidy comments which are no longer applicable --- .../src/test/java/io/quarkus/it/main/MethodSourceTest.java | 2 -- .../test/java/io/quarkus/it/main/ParameterResolverTest.java | 3 --- .../src/test/java/io/quarkus/it/extension/ParamsTest.java | 3 --- 3 files changed, 8 deletions(-) diff --git a/integration-tests/main/src/test/java/io/quarkus/it/main/MethodSourceTest.java b/integration-tests/main/src/test/java/io/quarkus/it/main/MethodSourceTest.java index f17579c86b365..c9836ec311839 100644 --- a/integration-tests/main/src/test/java/io/quarkus/it/main/MethodSourceTest.java +++ b/integration-tests/main/src/test/java/io/quarkus/it/main/MethodSourceTest.java @@ -33,12 +33,10 @@ public void testParameterResolver(UnusedBean.DummyInput dummyInput, Matcher provideDummyInput() { return List.of( Arguments.of( - // note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253 new UnusedBean.DummyInput("whatever", new UnusedBean.NestedDummyInput(new ArrayList<>(List.of(1, 2, 3)))), CoreMatchers.is("whatever/6")), Arguments.of( - // note: Collections.emptyList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253 new UnusedBean.DummyInput("hi", new UnusedBean.NestedDummyInput(new ArrayList<>())), CoreMatchers.is("hi/0"))); } diff --git a/integration-tests/main/src/test/java/io/quarkus/it/main/ParameterResolverTest.java b/integration-tests/main/src/test/java/io/quarkus/it/main/ParameterResolverTest.java index 949e5be3f72e7..eeb168fac0518 100644 --- a/integration-tests/main/src/test/java/io/quarkus/it/main/ParameterResolverTest.java +++ b/integration-tests/main/src/test/java/io/quarkus/it/main/ParameterResolverTest.java @@ -61,7 +61,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon @Override public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException { - // note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253 return new UnusedBean.DummyInput("whatever", new UnusedBean.NestedDummyInput(new ArrayList<>(List.of(1, 2, 3)))); } } @@ -78,7 +77,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException { return (Supplier) () -> new UnusedBean.DummyInput("fromSupplier", - // note: Collections.emptyList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253 new UnusedBean.NestedDummyInput(new ArrayList<>())); } } @@ -109,7 +107,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon @Override public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException { - // note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253 return new ArrayList<>(List.of(new NonSerializable("foo"), new NonSerializable("bar"))); } } diff --git a/integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java b/integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java index f799a7183d5fa..391c0c5e2fa3b 100644 --- a/integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java +++ b/integration-tests/test-extension/tests/src/test/java/io/quarkus/it/extension/ParamsTest.java @@ -19,9 +19,6 @@ /** * Exercise {@link ParameterizedTest @ParameterizedTest}s. * - *

- * This test will run into x-stream/xstream#253 on Java 16 and - * newer if the custom XStream converters are not used */ @QuarkusTest public class ParamsTest {