From 61d1823ee4d156e02996425588840afb1b944719 Mon Sep 17 00:00:00 2001 From: Jakub Gardo Date: Fri, 1 Nov 2024 22:59:11 +0100 Subject: [PATCH] Fix Pulsar DevService network for @QuarkusIntegrationTest for docker-image-building --- .../PulsarDevServicesProcessor.java | 27 ++++++++++++++++--- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/extensions/smallrye-reactive-messaging-pulsar/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/pulsar/deployment/PulsarDevServicesProcessor.java b/extensions/smallrye-reactive-messaging-pulsar/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/pulsar/deployment/PulsarDevServicesProcessor.java index 3aa71a410c64b7..507b0a3ea9e752 100644 --- a/extensions/smallrye-reactive-messaging-pulsar/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/pulsar/deployment/PulsarDevServicesProcessor.java +++ b/extensions/smallrye-reactive-messaging-pulsar/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/pulsar/deployment/PulsarDevServicesProcessor.java @@ -3,6 +3,7 @@ import java.io.Closeable; import java.time.Duration; import java.util.HashMap; +import java.util.List; import java.util.Map; import java.util.Objects; import java.util.Optional; @@ -21,12 +22,14 @@ import io.quarkus.deployment.builditem.CuratedApplicationShutdownBuildItem; import io.quarkus.deployment.builditem.DevServicesResultBuildItem; import io.quarkus.deployment.builditem.DevServicesResultBuildItem.RunningDevService; +import io.quarkus.deployment.builditem.DevServicesSharedNetworkBuildItem; import io.quarkus.deployment.builditem.DockerStatusBuildItem; import io.quarkus.deployment.builditem.LaunchModeBuildItem; import io.quarkus.deployment.console.ConsoleInstalledBuildItem; import io.quarkus.deployment.console.StartupLogCompressor; import io.quarkus.deployment.dev.devservices.GlobalDevServicesConfig; import io.quarkus.deployment.logging.LoggingSetupBuildItem; +import io.quarkus.devservices.common.ConfigureUtil; import io.quarkus.devservices.common.ContainerLocator; import io.quarkus.runtime.LaunchMode; import io.quarkus.runtime.configuration.ConfigUtils; @@ -48,6 +51,7 @@ public class PulsarDevServicesProcessor { private static final ContainerLocator pulsarContainerLocator = new ContainerLocator(DEV_SERVICE_LABEL, PulsarContainer.BROKER_PORT); + private static final String DEV_SERVICE_PULSAR = "pulsar"; private static final String PULSAR_CLIENT_SERVICE_URL = "pulsar.client.serviceUrl"; private static final String PULSAR_ADMIN_SERVICE_URL = "pulsar.admin.serviceUrl"; static volatile RunningDevService devService; @@ -59,12 +63,15 @@ public DevServicesResultBuildItem startPulsarDevService( DockerStatusBuildItem dockerStatusBuildItem, LaunchModeBuildItem launchMode, PulsarBuildTimeConfig pulsarClientBuildTimeConfig, + List devServicesSharedNetworkBuildItem, Optional consoleInstalledBuildItem, CuratedApplicationShutdownBuildItem closeBuildItem, LoggingSetupBuildItem loggingSetupBuildItem, GlobalDevServicesConfig devServicesConfig) { PulsarDevServiceCfg configuration = getConfiguration(pulsarClientBuildTimeConfig); + boolean useSharedNetwork = DevServicesSharedNetworkBuildItem.isSharedNetworkRequired(devServicesConfig, + devServicesSharedNetworkBuildItem); if (devService != null) { boolean shouldShutdownTheBroker = !configuration.equals(cfg); @@ -80,7 +87,7 @@ public DevServicesResultBuildItem startPulsarDevService( loggingSetupBuildItem); try { RunningDevService newDevService = startPulsarContainer(dockerStatusBuildItem, configuration, launchMode, - devServicesConfig.timeout); + useSharedNetwork, devServicesConfig.timeout); if (newDevService != null) { devService = newDevService; Map config = devService.getConfig(); @@ -138,7 +145,8 @@ private void shutdownBroker() { } private RunningDevService startPulsarContainer(DockerStatusBuildItem dockerStatusBuildItem, PulsarDevServiceCfg config, - LaunchModeBuildItem launchMode, Optional timeout) { + LaunchModeBuildItem launchMode, + boolean useSharedNetwork, Optional timeout) { if (!config.devServicesEnabled) { // explicitly disabled log.debug("Not starting Dev Services for Pulsar, as it has been disabled in the config."); @@ -175,10 +183,21 @@ private RunningDevService startPulsarContainer(DockerStatusBuildItem dockerStatu container.withPort(config.fixedExposedPort); } timeout.ifPresent(container::withStartupTimeout); + String hostName = null; + if (useSharedNetwork) { + hostName = ConfigureUtil.configureSharedNetwork(container, DEV_SERVICE_PULSAR); + } container.start(); - return getRunningService(container.getContainerId(), container::close, container.getPulsarBrokerUrl(), - container.getHttpServiceUrl()); + var pulsarBrokerUrl = container.getPulsarBrokerUrl(); + var httpHostServiceUrl = container.getHttpServiceUrl(); + if (useSharedNetwork) { + pulsarBrokerUrl = getServiceUrl(hostName, PulsarContainer.BROKER_PORT); + httpHostServiceUrl = getHttpServiceUrl(hostName, PulsarContainer.BROKER_HTTP_PORT); + } + + return getRunningService(container.getContainerId(), container::close, pulsarBrokerUrl, + httpHostServiceUrl); }; return pulsarContainerLocator.locateContainer(config.serviceName, config.shared, launchMode.getLaunchMode())