Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stork env vars not working properly when deployed to k8s #404

Closed
edeandrea opened this issue Nov 7, 2023 · 4 comments
Closed

Stork env vars not working properly when deployed to k8s #404

edeandrea opened this issue Nov 7, 2023 · 4 comments
Assignees
@edeandrea
Labels
bug Something isn't working fights-service Fights service waiting-for/quarkus-release Waiting on something in Quarkus to be released

Comments

@edeandrea
Copy link
Collaborator

edeandrea commented Nov 7, 2023 •
edited
Loading

As of Quarkus 3.5.0 you can no longer use lowercase & . notation for environment variable keys (see https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.5#kubernetes-environment-variables). Because of this, we changed our k8s ConfigMaps to use uppercase with underscore. We quickly found out that this broke the Stork service discovery configuration.

This has been fixed in smallrye/smallrye-config#1041 and smallrye/smallrye-config#1036.

We need to wait for this to trickle into a Quarkus version before this gets fixed here.
@edeandrea edeandrea added bug Something isn't working fights-service Fights service labels Nov 7, 2023
@edeandrea edeandrea self-assigned this Nov 7, 2023
@edeandrea
Copy link
Collaborator Author

@aureamunoz / @radcortez could you please let me know once those changes make it into a Quarkus release?

@radcortez
Copy link
Member

Follow this one: quarkusio/quarkus#36917 :)

@edeandrea edeandrea added the waiting-for/quarkus-release Waiting on something in Quarkus to be released label Nov 7, 2023
@edeandrea edeandrea mentioned this issue Nov 8, 2023
Merged
@edeandrea
Copy link
Collaborator Author

This is also related to quarkusio/quarkus#36856

@edeandrea edeandrea mentioned this issue Nov 8, 2023
Closed
@edeandrea
Copy link
Collaborator Author

ae56ad2 and #423 should resolve this. I will wait until CI has gone through before closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edeandrea edeandrea

Labels
bug Something isn't working fights-service Fights service waiting-for/quarkus-release Waiting on something in Quarkus to be released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edeandrea @radcortez