Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cancellation message after push less scary #98

Closed
famod opened this issue May 4, 2021 · 4 comments
Closed

Make cancellation message after push less scary #98

famod opened this issue May 4, 2021 · 4 comments

Comments

@famod
Copy link
Member

famod commented May 4, 2021

quarkusio/quarkus#16980 (comment)

I wonder if the bot could detect that the workflow was cancelled due to a (another) push and make the message look less "scary".

@famod
Copy link
Member Author

famod commented May 5, 2021

...or even don't post a message at all.

@gsmet
Copy link
Member

gsmet commented May 10, 2021

I had a look at this one and... the sender is the user who pushed the changes not the bot itself so I have no idea who/what cancelled the workflow.

So basically we have two options:

  • do not post a comment at all when cancelled
  • keep the current behavior

@famod
Copy link
Member Author

famod commented May 10, 2021

Just spitballing: The bot knows the branch, no?
Couldn't it compare the sha of the current HEAD of the branch to the sha that triggered the workflow run?

@gsmet
Copy link
Member

gsmet commented Jul 19, 2021

These messages should be gone now... but I think I saw one popping so I wonder if there isn't some sort of weird corner case... Let's see how it goes and reopen if necessary.

@gsmet gsmet closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants