Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include reason for mention/cc #297

Closed
maxandersen opened this issue Nov 29, 2022 · 4 comments
Closed

include reason for mention/cc #297

maxandersen opened this issue Nov 29, 2022 · 4 comments

Comments

@maxandersen
Copy link
Member

in my constant battle on tuning my ever growing notification inflow I was wondering if this change to quarkus bot would be useful to others:

Instead of just seeing

/cc @gsmet, @manovotn, @maxandersen, @radcortez, @Sanne

on a PR/issue like quarkusio/quarkus#29537 I was thinking to do this:

/cc @gsmet(deps), @manovotn(smallrye), @maxandersen(deps), @radcortez(smallrye), @Sanne(deps)

Letting me know at a faster glance reason why I'm being pinged.

Implementation idea is simply to add optional id to the matchers in quarkus-bot.yaml and whatever id gets matched first add that as reason to a mention.

Could also add all reasons but feels like it could get quite long for some ?

If interesting I can have a stab at it.

@gsmet
Copy link
Member

gsmet commented Dec 14, 2022

Fixed in #299 .

@gsmet gsmet closed this as completed Dec 14, 2022
@maxandersen
Copy link
Member Author

is it live now?

@maxandersen
Copy link
Member Author

ah i see it now - its live. awesomeness.

@gsmet
Copy link
Member

gsmet commented Dec 15, 2022

Yeah, I pushed it yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants