Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @quarkusbot rebase command #23

Closed
gastaldi opened this issue Mar 1, 2021 · 3 comments
Closed

Support @quarkusbot rebase command #23

gastaldi opened this issue Mar 1, 2021 · 3 comments

Comments

@gastaldi
Copy link
Contributor

gastaldi commented Mar 1, 2021

It would be nice if one could do @quarkusbot rebase and have Quarkus bot to automatically rebase any PR (like @dependabot rebase does)
@gastaldi gastaldi mentioned this issue Apr 13, 2021
Open
@gastaldi gastaldi changed the title Support Rebase command Support @quarkusbot rebase command Apr 13, 2021
@geoand geoand mentioned this issue Jun 17, 2021
Closed
@gsmet
Copy link
Member

gsmet commented Jun 21, 2021

hey @gastaldi , you mentioned you had a working prototype for this one? @Luke1432 will be joining us for a month soon and maybe he could help finalizing this.

@gastaldi
Copy link
Contributor Author

@gsmet I had but I just noticed that I discarded when I re-checked out the sources 😞

What I did in the bot was to:

  1. Clone the main repository branch.
  2. Listen for merges to the main branch and update the working copy locally
  3. When the @quarkusbot rebase command is issued, the PR would rebase against this local working copy and force-push

Obviously that would fail if the PR had conflicts.

@gastaldi
Copy link
Contributor Author

This is already supported in GitHub UI. Closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gastaldi @gsmet