Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate extension images #23

Closed
5 tasks done
holly-cummins opened this issue Nov 18, 2022 · 1 comment · Fixed by #64
Closed
5 tasks done

Populate extension images #23

holly-cummins opened this issue Nov 18, 2022 · 1 comment · Fixed by #64

Comments

@holly-cummins
Copy link
Collaborator

holly-cummins commented Nov 18, 2022

We can do this in several ways, and should do some of them:

Extensions in the quarkus repo will need a manual override to avoid a sea of Quarkus logos appearing on the main page. However, we don't want to force people to manually enter information that's already available elsewhere.

I think we may be able to mostly do the right thing for the GitHub repository image. If you look at something like this, it's not suitable:

image

But something like this should be used.

image

The difference is one is set by the user, and one is the github default. I don't think the github api distinguishes between the two, but we can use some heuristics. In particular, we'd only want to show images with no text. This is something we can detect.

We also would want to crop. https://www.npmjs.com/package/smartcrop can probably help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant